Change to parentheses
This way we don't need to translate and create different strings for the "on", which will appear odd in languages other than English. I also added it for FIO and OpenAlias. Further, I removed the 1 instance of openalias_alert_title. It can be removed from the localization file if/when it's convenient. I did NOT change anything for Unstoppable, because that appeared to touch a dependency. That has its own custom (but similar) text response
Justin Ehrenhofer committed
Jan 30, 2023 at 15:18 UTC
81f59cacd984533700376db5ffc7218d48b52ded
2 files changed
+4
-4
lib/entities/parse_address_from_domain.dart
+3
-3
@@ -45,14 +45,14 @@ class AddressResolver {
45
final twitterUser = await TwitterApi.lookupUserByName(userName: formattedName);
46
final address = extractAddressByType(raw: twitterUser.description ?? '', type: CryptoCurrency.fromString(ticker));
47
if (address != null) {
48
- return ParsedAddress.fetchTwitterAddress(address: address, name: '$text on Twitter');
48
+ return ParsedAddress.fetchTwitterAddress(address: address, name: '$text (Twitter)');
49
}
50
}
51
if (!text.startsWith('@') && text.contains('@') && !text.contains('.')) {
52
final bool isFioRegistered = await FioAddressProvider.checkAvail(text);
53
if (isFioRegistered) {
54
final address = await FioAddressProvider.getPubAddress(text, ticker);
55
- return ParsedAddress.fetchFioAddress(address: address, name: text);
55
+ return ParsedAddress.fetchFioAddress(address: address, name: '$text (FIO)');
56
}
57
58
}
@@ -77,7 +77,7 @@ class AddressResolver {
77
78
final record = await OpenaliasRecord.fetchAddressAndName(
79
formattedName: formattedName, ticker: ticker);
80
- return ParsedAddress.fetchOpenAliasAddress(record: record, name: text);
80
+ return ParsedAddress.fetchOpenAliasAddress(record: record, name: '$text (OpenAlias)');
81
82
} catch (e) {
83
print(e.toString());
lib/src/screens/send/widgets/extract_address_from_parsed.dart
+1
-1
@@ -19,7 +19,7 @@ Future<String> extractAddressFromParsed(
19
address = parsedAddress.addresses.first;
20
break;
21
case ParseFrom.openAlias:
22
- title = S.of(context).openalias_alert_title;
22
+ title = S.of(context).address_detected;
23
content = S.of(context).openalias_alert_content(parsedAddress.name);
24
address = parsedAddress.addresses.first;
25
break;