send logs about trace only in debug mode (#2115)
cyan committed
Mar 26, 2025 at 02:34 UTC
72e011ead0fafd58e701a40d99e92ca6f96dfd54
9 files changed
+10
-9
.github/workflows/no_print_in_dart.yaml
+1
-1
@@ -11,7 +11,7 @@ jobs:
11
- name: Check for print() statements in dart code (use printV() instead)
12
if: github.event_name == 'pull_request'
13
run: |
14
- GIT_GREP_OUT="$(git grep ' print(' | (grep .dart: || test $? = 1) | (grep -v print_verbose.dart || test $? = 1) || true)"
14
+ GIT_GREP_OUT="$(git grep ' print(' | (grep .dart: || test $? = 1) | (grep -v print_verbose.dart || test $? = 1) | (grep -v print_verbose_dummy.dart || test $? = 1) || true)"
15
[[ "x$GIT_GREP_OUT" == "x" ]] && exit 0
16
echo "$GIT_GREP_OUT"
17
echo "There are .dart files which use print() statements"
cw_core/lib/utils/print_verbose.dart
+3
-2
@@ -1,4 +1,5 @@
1
import 'dart:math';
2
+import 'package:flutter/foundation.dart';
3
4
void printV(dynamic content) {
5
CustomTrace programInfo = CustomTrace(StackTrace.current);
@@ -20,7 +21,7 @@ class CustomTrace {
21
try {
22
_parseTrace();
23
} catch (e) {
23
- print("Unable to parse trace (printV): $e");
24
+ if (kDebugMode) print("Unable to parse trace (printV): $e");
25
}
26
}
27
@@ -80,7 +81,7 @@ class CustomTrace {
81
columnStr = columnStr.replaceFirst(")", "");
82
this.columnNumber = int.tryParse(columnStr);
83
} catch (e) {
83
- print("Unable to parse trace (printV): $e");
84
+ if (kDebugMode) print("Unable to parse trace (printV): $e");
85
}
86
}
87
}
tool/append_translation.dart
-1
@@ -1,4 +1,3 @@
1
-import 'package:cw_core/utils/print_verbose.dart';
1
2
import 'utils/translation/arb_file_utils.dart';
3
import 'utils/translation/translation_constants.dart';
tool/download_moneroc_prebuilds.dart
+1
-1
@@ -1,6 +1,6 @@
1
import 'dart:io';
2
3
-import 'package:cw_core/utils/print_verbose.dart';
3
+import './print_verbose_dummy.dart';
4
import 'package:dio/dio.dart';
5
import 'package:archive/archive_io.dart';
6
tool/generate_localization.dart
+1
-1
@@ -1,6 +1,6 @@
1
import 'dart:io';
2
import 'dart:convert';
3
-import 'package:cw_core/utils/print_verbose.dart';
3
+import './print_verbose_dummy.dart';
4
5
import 'localization/localization_constants.dart';
6
import 'utils/utils.dart';
tool/print_verbose_dummy.dart
new
+1
@@ -0,0 +1 @@
1
+void printV(dynamic content) => print(content);
\ No newline at end of file
tool/translation_add_lang.dart
+1
-1
@@ -1,6 +1,6 @@
1
import 'dart:io';
2
3
-import 'package:cw_core/utils/print_verbose.dart';
3
+import './print_verbose_dummy.dart';
4
5
import 'utils/translation/arb_file_utils.dart';
6
import 'utils/translation/translation_constants.dart';
tool/translation_consistence.dart
+1
-1
@@ -1,6 +1,6 @@
1
import 'dart:io';
2
3
-import 'package:cw_core/utils/print_verbose.dart';
3
+import './print_verbose_dummy.dart';
4
5
import 'utils/translation/arb_file_utils.dart';
6
import 'utils/translation/translation_constants.dart';
tool/utils/translation/arb_file_utils.dart
+1
-1
@@ -1,7 +1,7 @@
1
import 'dart:convert';
2
import 'dart:io';
3
4
-import 'package:cw_core/utils/print_verbose.dart';
4
+import '../../print_verbose_dummy.dart';
5
6
void appendStringToArbFile(String fileName, String name, String text, {bool force = false}) {
7
final file = File(fileName);