fix sending issue (#1840)
* fix sending issue * Update pr_test_build_android.yml
Omar Hatem committed
Nov 29, 2024 at 22:15 UTC
bd38393acff73eb891eea84e073595580a13025d
4 files changed
+7
-16
.github/workflows/pr_test_build_android.yml
+1
-1
@@ -53,7 +53,7 @@ jobs:
53
- name: Flutter action
54
uses: subosito/flutter-action@v1
55
with:
56
- flutter-version: "3.24.4"
56
+ flutter-version: "3.24.0"
57
channel: stable
58
59
- name: Install package dependencies
android/app/src/main/AndroidManifestBase.xml
+2
-1
@@ -1,4 +1,5 @@
1
-<manifest xmlns:android="http://schemas.android.com/apk/res/android">
1
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
2
+ package="__APP_PACKAGE__">
3
4
<uses-permission android:name="android.permission.INTERNET" />
5
<uses-permission android:name="android.permission.USE_FINGERPRINT" />
lib/view_model/send/send_view_model.dart
-10
@@ -534,16 +534,6 @@ abstract class SendViewModelBase extends WalletChangeListenerViewModel with Stor
534
throw Exception('Priority is null for wallet type: ${wallet.type}');
535
}
536
537
- if (hasCoinControl) {
538
- bool isCoinSelected = false;
539
- for (var coin in unspentCoinsListViewModel.items) {
540
- isCoinSelected = isCoinSelected || (coin.isSending && !coin.isFrozen);
541
- }
542
- if (!isCoinSelected) {
543
- throw Exception("No coin selected in coin control, you need to select a coin in order to spend");
544
- }
545
- }
546
-
537
switch (wallet.type) {
538
case WalletType.bitcoin:
539
case WalletType.litecoin:
scripts/android/app_env.sh
+4
-4
@@ -15,15 +15,15 @@ TYPES=($MONERO_COM $CAKEWALLET $HAVEN)
15
APP_ANDROID_TYPE=$1
16
17
MONERO_COM_NAME="Monero.com"
18
-MONERO_COM_VERSION="1.18.1"
19
-MONERO_COM_BUILD_NUMBER=106
18
+MONERO_COM_VERSION="1.18.2"
19
+MONERO_COM_BUILD_NUMBER=107
20
MONERO_COM_BUNDLE_ID="com.monero.app"
21
MONERO_COM_PACKAGE="com.monero.app"
22
MONERO_COM_SCHEME="monero.com"
23
24
CAKEWALLET_NAME="Cake Wallet"
25
-CAKEWALLET_VERSION="4.21.1"
26
-CAKEWALLET_BUILD_NUMBER=237
25
+CAKEWALLET_VERSION="4.21.2"
26
+CAKEWALLET_BUILD_NUMBER=238
27
CAKEWALLET_BUNDLE_ID="com.cakewallet.cake_wallet"
28
CAKEWALLET_PACKAGE="com.cakewallet.cake_wallet"
29
CAKEWALLET_SCHEME="cakewallet"