fix: icon, order and comment features were not working for link items #1170
Massimo Melina committed
Feb 20, 2026 at 23:02 UTC
106fd9f3b7c3850d6d431c101a065c36668e3572
3 files changed
+18
-2
e2e/frontend.spec.ts
+6
@@ -357,3 +357,9 @@ test('anew', async ({ page, browserName }) => {
357
const page2 = await page2Promise
358
await page2.getByText(/folder1/).click()
359
})
360
+
361
+test('order field', async ({ page }) => {
362
+ await page.goto(URL + 'renameChild/orderTest/')
363
+ await expect(page.getByText('orderTest')).toBeVisible()
364
+ await expect(page.locator('.entry-name')).toHaveText(['B', 'A', 'C'])
365
+})
src/api.get_file_list.ts
+2
-2
@@ -111,8 +111,6 @@ export const get_file_list: ApiHandler = async ({ uri='/', offset, limit, c, onl
111
async function nodeToDirEntry(ctx: Koa.Context, node: VfsNode): Promise<DirEntry | null> {
112
const { source, url } = node
113
const name = getNodeName(node)
114
- if (url)
115
- return name ? { n: name, url, target: node.target } : null
114
const isFolder = nodeIsFolder(node)
115
try {
116
const st = source ? await (node.stats || statWithTimeout(source).catch(e => {
@@ -137,6 +135,8 @@ export const get_file_list: ApiHandler = async ({ uri='/', offset, limit, c, onl
135
m: !st || Math.abs(st.mtimeMs - st.birthtimeMs) < 1000 ? undefined : st.mtime,
136
s: isFolder ? undefined : st?.size,
137
p: (pr + pl + pd + pa + pu) || undefined,
138
+ url,
139
+ target: node.target,
140
order: node.order,
141
comment: node.comment ?? await getCommentFor(source),
142
icon: getNodeIcon(node),
tests/config.yaml
+10
@@ -75,6 +75,16 @@ vfs:
75
rename:
76
alfa.txt: renamed1
77
page/gpl.png: renamed2
78
+ - name: orderTest
79
+ can_see: true
80
+ children:
81
+ - name: A
82
+ order: -2
83
+ url: asd
84
+ - name: B
85
+ order: -1
86
+ - name: C
87
+ order: -3
88
- name: cantListBut
89
source: ..
90
can_list: false