fix: linux-arm binary not working when cross-compiled (after introducing node24)
Massimo Melina committed
May 24, 2026 at 11:17 UTC
5e195fcbf85163cc0fce69b2d4f5b1d4fb0fc861
2 files changed
+9
-9
.github/workflows/docker-image.yml
+7
-7
@@ -20,30 +20,30 @@ jobs:
20
runs-on: ubuntu-latest
21
steps:
22
- name: Checkout
23
- uses: actions/checkout@v4
23
+ uses: actions/checkout@v5
24
25
- name: Set up QEMU
26
- uses: docker/setup-qemu-action@v3
26
+ uses: docker/setup-qemu-action@v4
27
28
- name: Set up Docker Buildx
29
- uses: docker/setup-buildx-action@v3
29
+ uses: docker/setup-buildx-action@v4
30
31
- name: Log in to GHCR
32
- uses: docker/login-action@v3
32
+ uses: docker/login-action@v4
33
with:
34
registry: ghcr.io
35
username: ${{ github.actor }}
36
password: ${{ secrets.GITHUB_TOKEN }}
37
38
- name: Log in to Docker Hub
39
- uses: docker/login-action@v3
39
+ uses: docker/login-action@v4
40
with:
41
username: rejetto
42
password: ${{ secrets.DOCKERHUB_TOKEN }}
43
44
- name: Docker metadata
45
id: meta
46
- uses: docker/metadata-action@v5
46
+ uses: docker/metadata-action@v6
47
with:
48
# disable the action's automatic latest tag so prereleases cannot overwrite latest
49
flavor: |
@@ -60,7 +60,7 @@ jobs:
60
type=sha
61
62
- name: Build and push
63
- uses: docker/build-push-action@v6
63
+ uses: docker/build-push-action@v7
64
with:
65
context: .
66
file: ./Dockerfile
package.json
+2
-2
@@ -33,8 +33,8 @@
33
"dist-bin-win": "cd dist && pkg . --public -C gzip -t node24-win-x64 && npx resedit-cli --in hfs.exe --icon 1,../hfs.ico --out hfs.exe && zip hfs-windows-x64-$(jq -r .version ../package.json).zip hfs.exe -r plugins && cd ..",
34
"dist-bin-mac-arm": "cd dist && pkg . --public -C gzip -t node24-macos-arm64 && zip hfs-mac-arm64-$(jq -r .version ../package.json).zip hfs -r plugins && cd ..",
35
"dist-bin-mac": "cd dist && pkg . --public -C gzip -t node24-macos-x64 && zip hfs-mac-x64-$(jq -r .version ../package.json).zip hfs -r plugins && cd ..",
36
- "dist-bin-linux": "cd dist && pkg . --public -C gzip -t node24-linux-x64 && zip hfs-linux-x64-$(jq -r .version ../package.json).zip hfs -r plugins && cd ..",
37
- "dist-bin-linux-arm": "cd dist && pkg . --public -C gzip -t node24-linux-arm64 ${GITHUB_ACTIONS:+--public-packages \"*\"} && zip hfs-linux-arm64-$(jq -r .version ../package.json).zip hfs -r plugins && cd ..",
36
+ "dist-bin-linux": "cd dist && pkg . --public --public-packages \"*\" -C gzip -t node24-linux-x64 && zip hfs-linux-x64-$(jq -r .version ../package.json).zip hfs -r plugins && cd ..",
37
+ "dist-bin-linux-arm": "cd dist && pkg . --public --public-packages \"*\" -C gzip -t node24-linux-arm64 && zip hfs-linux-arm64-$(jq -r .version ../package.json).zip hfs -r plugins && cd ..",
38
"dist-win": "npm run dist-modules && npm run dist-bin-win",
39
"dist-mac-arm": "npm run dist-modules && npm run dist-bin-mac-arm",
40
"dist-mac": "npm run dist-modules && npm run dist-bin-mac",