avoid history pollution
Massimo Melina committed
Jul 13, 2023 at 22:29 UTC
7c12a12b802179e1d86ee3e35915801d18e226c7
1 file changed
+5
-3
frontend/src/fileMenu.ts
+5
-3
@@ -82,9 +82,11 @@ export function openFileMenu(entry: DirEntry, ev: MouseEvent, addToMenu: (FileMe
82
: !e?.label ? null :
83
h('a', {
84
key: i,
85
- href: e.href || '#',
86
- ..._.omit(e, ['label', 'icon', 'href', 'onClick']),
87
- async onClick() {
85
+ href: '#',
86
+ ..._.omit(e, ['label', 'icon', 'onClick']),
87
+ async onClick(ev: MouseEvent) {
88
+ if (!e.href) // even with #, the
89
+ ev.preventDefault()
90
if ((await e.onClick?.()) !== false)
91
close()
92
}