avoid redundant request

Massimo Melina committed Aug 27, 2023 at 19:57 UTC 9097bc01a830e5fe656fc8e4e8da84739ba2f25e
1 file changed +3 -5
admin/src/MainMenu.ts
+3 -5
@@ -27,7 +27,7 @@ import LogoutPage from './LogoutPage';
27 import LangPage from './LangPage'
28 import LogsPage from './LogsPage';
29 import PluginsPage from './PluginsPage';
30 -import { useApi } from './api'
30 +import { getHFS } from '@hfs/shared'
31 import CustomHtmlPage from './CustomHtmlPage';
32 import InternetPage from './InternetPage'
33
@@ -53,10 +53,8 @@ export const mainMenu: MenuEntry[] = [
53 { path: 'logout', icon: Logout, comp: LogoutPage }
54 ]
55
56 -let version: any // cache 'version', as it won't change at runtime, while the Drawer mechanism will unmount our menu each time
56 export default function Menu({ onSelect }: { onSelect: ()=>void }) {
58 - const [status] = useApi(!version && 'get_status')
59 - version ||= status?.version?.replace('-', ' ')
57 + const { VERSION } = getHFS()
58 return h(Box, { display: 'flex', flexDirection: 'column', bgcolor: 'primary.main', minHeight: '100%', },
59 h(List, {
60 sx:{
@@ -69,7 +67,7 @@ export default function Menu({ onSelect }: { onSelect: ()=>void }) {
67 },
68 h(Box, { display: 'flex', px: 2, py: 1, gap: 2, alignItems: 'flex-end' },
69 h(Box, { fontSize: 'min(3rem, 5vh)' }, 'HFS'),
72 - h(Box, { pb: 1, fontSize: 'small' }, version),
70 + h(Box, { pb: 1, fontSize: 'small' }, VERSION?.replace('-', ' ')),
71 ),
72 mainMenu.map(it =>
73 h(ListItemButton, {