@samitouri / QOSami-HFS / commits / 4ea66be5

ux: admin/fs: "access folder" is not a good name for list action, because you can still access folders as web without list-ing

Massimo Melina committed Jun 4, 2024 at 10:44 UTC 4ea66be5e770202acc71bb52ce9c0deadfd080bb
2 files changed +5 -5
admin/src/FileForm.ts
+4 -4
@@ -153,10 +153,10 @@ export default function FileForm({ file, addToBar, statusApi, accounts, saved }:
153 },
154 { k: 'id', comp: LinkField, statusApi, xs: 12 },
155 perm('can_read', "Who can see but not download will be asked to login"),
156 - perm('can_see', "If you can't see, you may still download with a direct link"),
156 + perm('can_see', ["Control what appears in the list.", wikiLink('Permissions', " More help.")]),
157 perm('can_archive', "Should this be included when user downloads as ZIP", { lg: isDir ? 6 : 12 }),
158 perm('can_delete', [needSourceWarning, "Those who can delete can also rename and cut/move"]),
159 - perm('can_list', undefined, { contentText: "subfolders" }),
159 + perm('can_list', "Permission to requests the list of a folder. The list will include only things you can see.", { contentText: "subfolders" }),
160 perm('can_upload', needSourceWarning, { contentText: "subfolders" }),
161 isLink && {
162 k: 'target',
@@ -172,7 +172,7 @@ export default function FileForm({ file, addToBar, statusApi, accounts, saved }:
172 showAccept && { k: 'accept', label: "Accept on upload", placeholder: "anything", xl: showWebsite ? 4 : 12,
173 helperText: h(Link, { href: ACCEPT_LINK, target: '_blank' }, "Example: .zip") },
174 showWebsite && { k: 'default', comp: BoolField, xl: true,
175 - label: "Serve as website if index.html is found" + (inheritedDefault && values.default == null ? ' (inherited)' : ''),
175 + label: "Serve as web-page if index.html is found" + (inheritedDefault && values.default == null ? ' (inherited)' : ''),
176 value: values.default ?? inheritedDefault,
177 toField: Boolean, fromField: (v:boolean) => v && !inheritedDefault ? 'index.html' : v ? null : false,
178 helperText: md("...instead of showing list of files")
@@ -208,7 +208,7 @@ export default function FileForm({ file, addToBar, statusApi, accounts, saved }:
208 }
209
210 function perm2word(perm: string) {
211 - return xlate(perm.split('_')[1], { read: 'download', archive: 'zip', list: 'access folder' })
211 + return xlate(perm.split('_')[1], { read: 'download', archive: 'zip', list: 'access list' })
212 }
213
214 interface WhoFieldProps extends FieldProps<Who | undefined> {
admin/src/VfsTree.ts
+1 -1
@@ -92,7 +92,7 @@ export default function VfsTree({ id2node, statusApi }:{ id2node: Map<string, Vf
92 !isRoot && !node.source && !node.url && iconTooltip(Cloud, "Virtual (no source)"),
93 isRestricted(node.can_see) && iconTooltip(RemoveRedEye, "Restrictions on who can see"),
94 isRestricted(node.can_read) && iconTooltip(Lock, "Restrictions on who can download"),
95 - node.default && iconTooltip(Web, "Act as website"),
95 + node.default && iconTooltip(Web, "Show as web-page"),
96 node.masks && iconTooltip(TheaterComedy, "Masks"),
97 node.size === -1 && iconTooltip(HighlightOff, "Source not found"),
98 with_(_.findKey(statusApi.data?.roots, root => root === id.slice(1)), host =>