@samitouri / QOSamiQemu / commits / 03071f99a3

hw/dma/i8257: Return zeroes for read_memory in verify mode

The i8257 DMA controller has a "verify" mode, which the datasheet describes like this: > DMA verify, which does not actually involve the transfer of data. > When an 8257 channel is in the DMA verify mode, it will respond the > same as described for transfer operations, except that no memory or > I/O read/write control signals will be generated. When an 8257 > channel is in the DMA verify mode, it will respond the same as > described for transfer operations, except that no memory or I/O read > /write control signals will be generated, thus preventing the > transfer of data. The 8257, however, will gain control of the system > bus and will acknowledge the peripheral's DMA request for each DMA > cycle. The perihperal can use these acknowledge signals to enable an > internal access of each byte of a data block in order to execute some > verification procedure, such as the accumulation of a CRC check word. In practice, for QEMU's purposes the only real user of this is the floppy controller, which can be made to perform a "read data from floppy disk and check the checksum" by telling the fdc to do a read and the DMA controller to do a verify. This causes the fdc to do all the usual read actions including the checksum, but the data is never written to memory. However, it is possible for a guest doing something silly to program the DMA controller to do a verify operation for a device that wants to read from memory. Currently we simply return early from i8257_dma_read_memory() without writing to the buffer. None of the callers (the GUS, sb16 and cs4231a sound cards, plus the fdc) expect this, so they will take the uninitialized data as if it were from the guest. This can cause us to leak host data off the stack into the guest. Make i8257_dma_read_memory() fill the buffer with zeroes rather than leaving it untouched for a verify operation. Cc: qemu-stable@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3487 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Message-ID: <20260629140128.1900095-1-peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>

Peter Maydell committed Jun 29, 2026 at 15:01 UTC 03071f99a3e1549b3acc9b9534961632df016f76

1 file changed +13

hw/dma/i8257.c

+13

@@ -408,6 +408,19 @@ static int i8257_dma_read_memory(IsaDma *obj, int nchan, void *buf, int pos,

408 hwaddr addr = ((r->pageh & 0x7f) << 24) | (r->page << 16) | r->now[ADDR];

409

410 if (i8257_is_verify_transfer(r)) {

411 + /*

412 + * If the device is expecting this verify operation then

413 + * it won't care about the nonexistent data. But if it

414 + * is expecting a real read (i.e. the guest has misprogrammed

415 + * the DMA controller and the device) it's going to try to do

416 + * something with the buffer contents. Give it zeroes.

417 + * (It's not clear whether this is exactly what happens if

418 + * you do this on real hardware. In practice no device QEMU

419 + * emulates has a use for verify on a memory-read transfer,

420 + * so we don't care beyond avoiding the guest being able to

421 + * trigger the caller reading uninitialized data.)

422 + */

423 + memset(buf, 0, len);

424 return len;

425 }

426