@samitouri / QOSamiQemu / commits / 0450e9d7bd

hw/pci-bridge/pcie_rp: Remove PCIESlot::disable_acs field

The PCIESlot::disable_acs boolean was only set in the hw_compat_3_1[] array, via the 'disable-acs=true' property. We removed all machines using that array, lets remove that property and all the code around it. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Message-Id: <20260307152635.83893-10-philmd@linaro.org>

Philippe Mathieu-Daudé committed Mar 7, 2026 at 12:57 UTC 0450e9d7bdd2a89313516680d18adec1962d5d18
2 files changed +1 -5
hw/pci-bridge/pcie_root_port.c
+1 -2
@@ -117,7 +117,7 @@ static void rp_realize(PCIDevice *d, Error **errp)
117 pcie_aer_root_init(d);
118 rp_aer_vector_update(d);
119
120 - if (rpc->acs_offset && !s->disable_acs) {
120 + if (rpc->acs_offset) {
121 pcie_acs_init(d, rpc->acs_offset);
122 }
123 return;
@@ -151,7 +151,6 @@ static void rp_exit(PCIDevice *d)
151 static const Property rp_props[] = {
152 DEFINE_PROP_BIT(COMPAT_PROP_PCP, PCIDevice, cap_present,
153 QEMU_PCIE_SLTCAP_PCP_BITNR, true),
154 - DEFINE_PROP_BOOL("disable-acs", PCIESlot, disable_acs, false),
154 };
155
156 static void rp_instance_post_init(Object *obj)
include/hw/pci/pcie_port.h
-3
@@ -60,9 +60,6 @@ struct PCIESlot {
60 PCIExpLinkWidth width;
61 bool flitmode;
62
63 - /* Disable ACS (really for a pcie_root_port) */
64 - bool disable_acs;
65 -
63 /* Indicates whether any type of hot-plug is allowed on the slot */
64 bool hotplug;
65