@samitouri / QOSamiQemu / commits / 0fec063f3d

hw/arm/omap: Remove unused omap_mpuio functions

The omap1.c file includes some functions which used to be used by the other OMAP SoC variants which we removed a while ago, but which we missed when doing that removal. They have no callers, so we can delete them. This code was the last user of hw_error() in this file, so we can also remove the hw-error.h include. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-id: 20260512203414.3633237-3-peter.maydell@linaro.org

Peter Maydell committed May 12, 2026 at 21:34 UTC 0fec063f3d71e80c5fedcb97f2b7e38e39f1df6f
2 files changed -29
hw/arm/omap1.c
-26
@@ -25,7 +25,6 @@
25 #include "target/arm/cpu.h"
26 #include "system/address-spaces.h"
27 #include "exec/cpu-common.h"
28 -#include "hw/core/hw-error.h"
28 #include "hw/core/irq.h"
29 #include "hw/core/qdev-properties.h"
30 #include "hw/arm/boot.h"
@@ -2095,31 +2094,6 @@ static struct omap_mpuio_s *omap_mpuio_init(MemoryRegion *memory,
2094 return s;
2095 }
2096
2098 -qemu_irq *omap_mpuio_in_get(struct omap_mpuio_s *s)
2099 -{
2100 - return s->in;
2101 -}
2102 -
2103 -void omap_mpuio_out_set(struct omap_mpuio_s *s, int line, qemu_irq handler)
2104 -{
2105 - if (line >= 16 || line < 0)
2106 - hw_error("%s: No GPIO line %i\n", __func__, line);
2107 - s->handler[line] = handler;
2108 -}
2109 -
2110 -void omap_mpuio_key(struct omap_mpuio_s *s, int row, int col, int down)
2111 -{
2112 - if (row >= 5 || row < 0)
2113 - hw_error("%s: No key %i-%i\n", __func__, col, row);
2114 -
2115 - if (down)
2116 - s->buttons[row] |= 1 << col;
2117 - else
2118 - s->buttons[row] &= ~(1 << col);
2119 -
2120 - omap_mpuio_kbd_update(s);
2121 -}
2122 -
2097 /* MicroWire Interface */
2098 struct omap_uwire_s {
2099 MemoryRegion iomem;
include/hw/arm/omap.h
-3
@@ -486,9 +486,6 @@ struct omap_uart_s *omap_uart_init(hwaddr base,
486 void omap_uart_reset(struct omap_uart_s *s);
487
488 struct omap_mpuio_s;
489 -qemu_irq *omap_mpuio_in_get(struct omap_mpuio_s *s);
490 -void omap_mpuio_out_set(struct omap_mpuio_s *s, int line, qemu_irq handler);
491 -void omap_mpuio_key(struct omap_mpuio_s *s, int row, int col, int down);
489
490 struct omap_uwire_s;
491