@samitouri / QOSamiQemu / commits / 1115ea01aa

ppc/pnv: Fix uninitialized MpiplProcDumpArea struct

Fix Coverity CID 1658041 by using designated initializers to prevent uninitialized memory from being written to guest. Cc: Aditya Gupta <adityag@linux.ibm.com> Cc: Harsh Prateek Bora <harshpb@linux.ibm.com> Reported-by: Peter Maydell <peter.maydell@linaro.org> Suggested-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>" Reviewed-by: Aditya Gupta <adityag@linux.ibm.com> Link: https://lore.kernel.org/qemu-devel/20260508142029.624039-1-shivangu@linux.ibm.com Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>

Shivang Upadhyay committed May 8, 2026 at 19:50 UTC 1115ea01aa66cd957b94893b84e2a44b07204c9a
1 file changed +4 -12
hw/ppc/pnv.c
+4 -12
@@ -838,18 +838,10 @@ static void pnv_reset(MachineState *machine, ResetType type)
838 * crash
839 */
840
841 - MpiplProcDumpArea proc_area;
842 -
843 - proc_area.version = PROC_DUMP_AREA_VERSION_P9;
844 - proc_area.thread_size = cpu_to_be32(sizeof(MpiplPreservedCPUState));
845 -
846 - /* These are to be allocated & assigned by the firmware */
847 - proc_area.alloc_addr = 0;
848 - proc_area.alloc_size = 0;
849 -
850 - /* These get assigned after crash, when QEMU preserves the registers */
851 - proc_area.dest_addr = 0;
852 - proc_area.act_size = 0;
841 + MpiplProcDumpArea proc_area = {
842 + .version = PROC_DUMP_AREA_VERSION_P9,
843 + .thread_size = cpu_to_be32(sizeof(MpiplPreservedCPUState)),
844 + };
845
846 cpu_physical_memory_write(PROC_DUMP_AREA_OFF, &proc_area,
847 sizeof(proc_area));