@samitouri / QOSamiQemu / commits / 11a4f9576a

hw/pci-host/aspeed_pcie: Convert to DEFINE_TYPES() with inlined TypeInfo

Replace the legacy type_register_static()/type_init() registration pattern with the modern DEFINE_TYPES() macro. Inline 6 standalone TypeInfo variables (aspeed_pcie_phy_info, aspeed_2700_pcie_phy_info aspeed_pcie_root_port_info, aspeed_pcie_rc_info, aspeed_pcie_cfg_info and aspeed_2700_pcie_cfg_info directly into the 'aspeed_pcie_types[]' array, removing the need for separate declarations. No functional change. Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> Reviewed-by: Cédric Le Goater <clg@redhat.com> Link: https://lore.kernel.org/qemu-devel/20260601024959.2347639-22-jamin_lin@aspeedtech.com Signed-off-by: Cédric Le Goater <clg@redhat.com>

Jamin Lin committed Jun 1, 2026 at 02:50 UTC 11a4f9576ad5d0581aa90ee393168c52ed4bce89
1 file changed +41 -53
hw/pci-host/aspeed_pcie.c
+41 -53
@@ -83,13 +83,6 @@ static void aspeed_pcie_root_port_class_init(ObjectClass *klass,
83 rpc->ssid = 0x1150;
84 }
85
86 -static const TypeInfo aspeed_pcie_root_port_info = {
87 - .name = TYPE_ASPEED_PCIE_ROOT_PORT,
88 - .parent = TYPE_PCIE_ROOT_PORT,
89 - .instance_size = sizeof(AspeedPCIERootPortState),
90 - .class_init = aspeed_pcie_root_port_class_init,
91 -};
92 -
86 /*
87 * PCIe Root Complex (RC)
88 */
@@ -305,14 +298,6 @@ static void aspeed_pcie_rc_class_init(ObjectClass *klass, const void *data)
298 msi_nonbroken = true;
299 }
300
308 -static const TypeInfo aspeed_pcie_rc_info = {
309 - .name = TYPE_ASPEED_PCIE_RC,
310 - .parent = TYPE_PCIE_HOST_BRIDGE,
311 - .instance_size = sizeof(AspeedPCIERcState),
312 - .instance_init = aspeed_pcie_rc_instance_init,
313 - .class_init = aspeed_pcie_rc_class_init,
314 -};
315 -
301 /*
302 * PCIe Config
303 *
@@ -679,15 +664,6 @@ static void aspeed_pcie_cfg_class_init(ObjectClass *klass, const void *data)
664 apc->rc_rp_addr = PCI_DEVFN(8, 0);
665 }
666
682 -static const TypeInfo aspeed_pcie_cfg_info = {
683 - .name = TYPE_ASPEED_PCIE_CFG,
684 - .parent = TYPE_SYS_BUS_DEVICE,
685 - .instance_init = aspeed_pcie_cfg_instance_init,
686 - .instance_size = sizeof(AspeedPCIECfgState),
687 - .class_init = aspeed_pcie_cfg_class_init,
688 - .class_size = sizeof(AspeedPCIECfgClass),
689 -};
690 -
667 static void aspeed_2700_pcie_cfg_write(void *opaque, hwaddr addr,
668 uint64_t data, unsigned int size)
669 {
@@ -798,12 +774,6 @@ static void aspeed_2700_pcie_cfg_class_init(ObjectClass *klass,
774 apc->rc_rp_addr = PCI_DEVFN(0, 0);
775 }
776
801 -static const TypeInfo aspeed_2700_pcie_cfg_info = {
802 - .name = TYPE_ASPEED_2700_PCIE_CFG,
803 - .parent = TYPE_ASPEED_PCIE_CFG,
804 - .class_init = aspeed_2700_pcie_cfg_class_init,
805 -};
806 -
777 /*
778 * PCIe PHY
779 *
@@ -926,14 +896,6 @@ static void aspeed_pcie_phy_class_init(ObjectClass *klass, const void *data)
896 apc->nr_regs = 0x100 >> 2;
897 }
898
929 -static const TypeInfo aspeed_pcie_phy_info = {
930 - .name = TYPE_ASPEED_PCIE_PHY,
931 - .parent = TYPE_SYS_BUS_DEVICE,
932 - .instance_size = sizeof(AspeedPCIEPhyState),
933 - .class_init = aspeed_pcie_phy_class_init,
934 - .class_size = sizeof(AspeedPCIEPhyClass),
935 -};
936 -
899 static void aspeed_2700_pcie_phy_reset_hold(Object *obj, ResetType type)
900 {
901 AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(obj);
@@ -961,21 +923,47 @@ static void aspeed_2700_pcie_phy_class_init(ObjectClass *klass,
923 apc->nr_regs = 0x800 >> 2;
924 }
925
964 -static const TypeInfo aspeed_2700_pcie_phy_info = {
965 - .name = TYPE_ASPEED_2700_PCIE_PHY,
966 - .parent = TYPE_ASPEED_PCIE_PHY,
967 - .class_init = aspeed_2700_pcie_phy_class_init,
968 -};
926 +static const TypeInfo aspeed_pcie_types[] = {
927 + {
928 + .name = TYPE_ASPEED_PCIE_RC,
929 + .parent = TYPE_PCIE_HOST_BRIDGE,
930 + .instance_size = sizeof(AspeedPCIERcState),
931 + .instance_init = aspeed_pcie_rc_instance_init,
932 + .class_init = aspeed_pcie_rc_class_init,
933 + },
934 + {
935 + .name = TYPE_ASPEED_PCIE_ROOT_PORT,
936 + .parent = TYPE_PCIE_ROOT_PORT,
937 + .instance_size = sizeof(AspeedPCIERootPortState),
938 + .class_init = aspeed_pcie_root_port_class_init,
939 + },
940 + {
941 + .name = TYPE_ASPEED_PCIE_CFG,
942 + .parent = TYPE_SYS_BUS_DEVICE,
943 + .instance_init = aspeed_pcie_cfg_instance_init,
944 + .instance_size = sizeof(AspeedPCIECfgState),
945 + .class_init = aspeed_pcie_cfg_class_init,
946 + .class_size = sizeof(AspeedPCIECfgClass),
947 + },
948 + {
949 + .name = TYPE_ASPEED_PCIE_PHY,
950 + .parent = TYPE_SYS_BUS_DEVICE,
951 + .instance_size = sizeof(AspeedPCIEPhyState),
952 + .class_init = aspeed_pcie_phy_class_init,
953 + .class_size = sizeof(AspeedPCIEPhyClass),
954 + },
955 + {
956 + .name = TYPE_ASPEED_2700_PCIE_PHY,
957 + .parent = TYPE_ASPEED_PCIE_PHY,
958 + .class_init = aspeed_2700_pcie_phy_class_init,
959 + },
960 + {
961 + .name = TYPE_ASPEED_2700_PCIE_CFG,
962 + .parent = TYPE_ASPEED_PCIE_CFG,
963 + .class_init = aspeed_2700_pcie_cfg_class_init,
964 + }
965
970 -static void aspeed_pcie_register_types(void)
971 -{
972 - type_register_static(&aspeed_pcie_rc_info);
973 - type_register_static(&aspeed_pcie_root_port_info);
974 - type_register_static(&aspeed_pcie_cfg_info);
975 - type_register_static(&aspeed_2700_pcie_cfg_info);
976 - type_register_static(&aspeed_pcie_phy_info);
977 - type_register_static(&aspeed_2700_pcie_phy_info);
978 -}
966 +};
967
980 -type_init(aspeed_pcie_register_types);
968 +DEFINE_TYPES(aspeed_pcie_types)
969