hw/misc/applesmc: Fix a typo setting MSSD key
In commit 1ddda5cd364 we meant to set MSSD=3, but due to a typo we ended setting MSSD=0. Convert the two other NATJ and MSSP keys to use hexadecimal notation to avoid similar copy/paste typos. Cc: qemu-stable@nongnu.org Fixes: 1ddda5cd364 ("AppleSMC device emulation") Reported-by: Matthew Jackson <matthew@pq.io> Signed-off-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com> Reviewed-by: Alexander Graf <agraf@csgraf.de> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com> Message-Id: <20260720115336.75063-1-philmd@oss.qualcomm.com>
Philippe Mathieu-Daudé committed
Jul 20, 2026 at 10:06 UTC
2142689d92ca87b53ad1a0a8d48f439baf17e13a
1 file changed
+3
-3
hw/misc/applesmc.c
+3
-3
@@ -333,9 +333,9 @@ static void applesmc_isa_realize(DeviceState *dev, Error **errp)
333
applesmc_add_key(s, "REV ", 6, "\x01\x13\x0f\x00\x00\x03");
334
applesmc_add_key(s, "OSK0", 32, s->osk);
335
applesmc_add_key(s, "OSK1", 32, s->osk + 32);
336
- applesmc_add_key(s, "NATJ", 1, "\0");
337
- applesmc_add_key(s, "MSSP", 1, "\0");
338
- applesmc_add_key(s, "MSSD", 1, "\0x3");
336
+ applesmc_add_key(s, "NATJ", 1, "\x00");
337
+ applesmc_add_key(s, "MSSP", 1, "\x00");
338
+ applesmc_add_key(s, "MSSD", 1, "\x03");
339
}
340
341
static void applesmc_unrealize(DeviceState *dev)