@samitouri / QOSamiQemu / commits / 234d8cb6f2

target/hexagon: add GVec overrides for HVX absolute difference

Reviewed-by: Marco Liebel <marco.liebel@oss.qualcomm.com> Link: https://lore.kernel.org/qemu-devel/20260807152241.1576334-5-brian.cain@oss.qualcomm.com Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>

Brian Cain committed Aug 7, 2026 at 08:22 UTC 234d8cb6f2e95cc5078b232943e47bc4f56170c3
5 files changed +116
target/hexagon/gen_tcg_hvx.h
+16
@@ -326,6 +326,22 @@ static inline void assert_vhist_tmp(DisasContext *ctx)
326 tcg_gen_gvec_mul(MO_16, VdV_off, VuV_off, VvV_off, \
327 VECTOR_SIZE_BYTE, VECTOR_SIZE_BYTE)
328
329 +#define fGEN_TCG_V6_vabsdiffub(SHORTCODE) \
330 + gen_gvec_uabsdiff(MO_8, VdV_off, VuV_off, VvV_off, \
331 + VECTOR_SIZE_BYTE, VECTOR_SIZE_BYTE)
332 +
333 +#define fGEN_TCG_V6_vabsdiffuh(SHORTCODE) \
334 + gen_gvec_uabsdiff(MO_16, VdV_off, VuV_off, VvV_off, \
335 + VECTOR_SIZE_BYTE, VECTOR_SIZE_BYTE)
336 +
337 +#define fGEN_TCG_V6_vabsdiffh(SHORTCODE) \
338 + gen_gvec_sabsdiff(MO_16, VdV_off, VuV_off, VvV_off, \
339 + VECTOR_SIZE_BYTE, VECTOR_SIZE_BYTE)
340 +
341 +#define fGEN_TCG_V6_vabsdiffw(SHORTCODE) \
342 + gen_gvec_sabsdiff(MO_32, VdV_off, VuV_off, VvV_off, \
343 + VECTOR_SIZE_BYTE, VECTOR_SIZE_BYTE)
344 +
345 /* Vector shift right - various forms */
346 #define fGEN_TCG_V6_vasrh(SHORTCODE) \
347 do { \
target/hexagon/genptr.c
+70
@@ -37,6 +37,76 @@
37
38 #include "genptr.h"
39
40 +static void gen_sabsdiff_i32(TCGv_i32 d, TCGv_i32 a, TCGv_i32 b)
41 +{
42 + TCGv_i32 t = tcg_temp_new_i32();
43 +
44 + tcg_gen_sub_i32(t, a, b);
45 + tcg_gen_sub_i32(d, b, a);
46 + tcg_gen_movcond_i32(TCG_COND_LT, d, a, b, d, t);
47 +}
48 +
49 +static void gen_sabsdiff_vec(unsigned vece, TCGv_vec d, TCGv_vec a, TCGv_vec b)
50 +{
51 + TCGv_vec t = tcg_temp_new_vec_matching(d);
52 +
53 + tcg_gen_smin_vec(vece, t, a, b);
54 + tcg_gen_smax_vec(vece, d, a, b);
55 + tcg_gen_sub_vec(vece, d, d, t);
56 +}
57 +
58 +void gen_gvec_sabsdiff(unsigned vece, uint32_t dofs, uint32_t aofs,
59 + uint32_t bofs, uint32_t oprsz, uint32_t maxsz)
60 +{
61 + static const TCGOpcode vecop_list[] = {
62 + INDEX_op_sub_vec, INDEX_op_smin_vec, INDEX_op_smax_vec, 0
63 + };
64 + static const GVecGen3 ops[4] = {
65 + [MO_16] = { .fniv = gen_sabsdiff_vec,
66 + .fno = gen_helper_gvec_sabsdiff_h,
67 + .opt_opc = vecop_list,
68 + .vece = MO_16 },
69 + [MO_32] = { .fni4 = gen_sabsdiff_i32,
70 + .fniv = gen_sabsdiff_vec,
71 + .fno = gen_helper_gvec_sabsdiff_w,
72 + .opt_opc = vecop_list,
73 + .vece = MO_32 },
74 + };
75 +
76 + tcg_debug_assert(vece == MO_16 || vece == MO_32);
77 + tcg_gen_gvec_3(dofs, aofs, bofs, oprsz, maxsz, &ops[vece]);
78 +}
79 +
80 +static void gen_uabsdiff_vec(unsigned vece, TCGv_vec d, TCGv_vec a, TCGv_vec b)
81 +{
82 + TCGv_vec t = tcg_temp_new_vec_matching(d);
83 +
84 + tcg_gen_umin_vec(vece, t, a, b);
85 + tcg_gen_umax_vec(vece, d, a, b);
86 + tcg_gen_sub_vec(vece, d, d, t);
87 +}
88 +
89 +void gen_gvec_uabsdiff(unsigned vece, uint32_t dofs, uint32_t aofs,
90 + uint32_t bofs, uint32_t oprsz, uint32_t maxsz)
91 +{
92 + static const TCGOpcode vecop_list[] = {
93 + INDEX_op_sub_vec, INDEX_op_umin_vec, INDEX_op_umax_vec, 0
94 + };
95 + static const GVecGen3 ops[4] = {
96 + [MO_8] = { .fniv = gen_uabsdiff_vec,
97 + .fno = gen_helper_gvec_uabsdiff_b,
98 + .opt_opc = vecop_list,
99 + .vece = MO_8 },
100 + [MO_16] = { .fniv = gen_uabsdiff_vec,
101 + .fno = gen_helper_gvec_uabsdiff_h,
102 + .opt_opc = vecop_list,
103 + .vece = MO_16 },
104 + };
105 +
106 + tcg_debug_assert(vece == MO_8 || vece == MO_16);
107 + tcg_gen_gvec_3(dofs, aofs, bofs, oprsz, maxsz, &ops[vece]);
108 +}
109 +
110 TCGv gen_read_reg(TCGv result, int num)
111 {
112 tcg_gen_mov_tl(result, hex_gpr[num]);
target/hexagon/genptr.h
+4
@@ -59,6 +59,10 @@ TCGv gen_get_half(TCGv result, int N, TCGv src, bool sign);
59 void gen_set_half(int N, TCGv result, TCGv src);
60 void gen_set_half_i64(int N, TCGv_i64 result, TCGv src);
61 void probe_noshuf_load(TCGv va, int s, int mi);
62 +void gen_gvec_sabsdiff(unsigned vece, uint32_t dofs, uint32_t aofs,
63 + uint32_t bofs, uint32_t oprsz, uint32_t maxsz);
64 +void gen_gvec_uabsdiff(unsigned vece, uint32_t dofs, uint32_t aofs,
65 + uint32_t bofs, uint32_t oprsz, uint32_t maxsz);
66
67 extern const target_ulong reg_immut_masks[TOTAL_PER_THREAD_REGS];
68
target/hexagon/helper.h
+5
@@ -108,6 +108,11 @@ DEF_HELPER_2(probe_pkt_scalar_store_s0, void, env, int)
108 DEF_HELPER_2(probe_hvx_stores, void, env, int)
109 DEF_HELPER_2(probe_pkt_scalar_hvx_stores, void, env, int)
110
111 +DEF_HELPER_FLAGS_4(gvec_sabsdiff_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32)
112 +DEF_HELPER_FLAGS_4(gvec_sabsdiff_w, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32)
113 +DEF_HELPER_FLAGS_4(gvec_uabsdiff_b, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32)
114 +DEF_HELPER_FLAGS_4(gvec_uabsdiff_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32)
115 +
116 #if !defined(CONFIG_USER_ONLY)
117 DEF_HELPER_3(raise_stack_overflow, void, env, i32, i32)
118 DEF_HELPER_2(swi, void, env, i32)
target/hexagon/op_helper.c
+21
@@ -35,6 +35,7 @@
35 #include "mmvec/macros.h"
36 #include "op_helper.h"
37 #include "cpu_helper.h"
38 +#include "tcg/tcg-gvec-desc.h"
39 #include "translate.h"
40 #ifndef CONFIG_USER_ONLY
41 #include "hw/hexagon/hexagon_globalreg.h"
@@ -1961,3 +1962,23 @@ void HELPER(pending_interrupt)(CPUHexagonState *env)
1962 printf("ERROR: bogus helper: " #tag "\n")
1963
1964 #include "helper_funcs_generated.c.inc"
1965 +
1966 +#define DO_ABSDIFF(NAME, TYPE, UTYPE) \
1967 +void HELPER(NAME)(void *vd, void *vn, void *vm, uint32_t desc) \
1968 +{ \
1969 + intptr_t i, oprsz = simd_oprsz(desc); \
1970 + UTYPE *d = vd; \
1971 + TYPE *n = vn, *m = vm; \
1972 + \
1973 + for (i = 0; i < oprsz / sizeof(TYPE); i++) { \
1974 + d[i] = n[i] < m[i] ? (UTYPE)m[i] - (UTYPE)n[i] \
1975 + : (UTYPE)n[i] - (UTYPE)m[i]; \
1976 + } \
1977 +}
1978 +
1979 +DO_ABSDIFF(gvec_sabsdiff_h, int16_t, uint16_t)
1980 +DO_ABSDIFF(gvec_sabsdiff_w, int32_t, uint32_t)
1981 +DO_ABSDIFF(gvec_uabsdiff_b, uint8_t, uint8_t)
1982 +DO_ABSDIFF(gvec_uabsdiff_h, uint16_t, uint16_t)
1983 +
1984 +#undef DO_ABSDIFF