@samitouri / QOSamiQemu / commits / 23e79ed4bf

accel/kvm: Make kvm_irqchip*notifier() declaration non target-specific

Commit 3607715a308 ("kvm: Introduce KVM irqchip change notifier") restricted the kvm_irqchip*notifier() declarations to target-specific files, guarding them under the NEED_CPU_H (later renamed as COMPILING_PER_TARGET) #ifdef check. This however prohibit building the kvm-stub.c file once: ../accel/stubs/kvm-stub.c:70:6: error: no previous prototype for function 'kvm_irqchip_add_change_notifier' [-Werror,-Wmissing-prototypes] 70 | void kvm_irqchip_add_change_notifier(Notifier *n) | ^ ../accel/stubs/kvm-stub.c:74:6: error: no previous prototype for function 'kvm_irqchip_remove_change_notifier' [-Werror,-Wmissing-prototypes] 74 | void kvm_irqchip_remove_change_notifier(Notifier *n) | ^ ../accel/stubs/kvm-stub.c:78:6: error: no previous prototype for function 'kvm_irqchip_change_notify' [-Werror,-Wmissing-prototypes] 78 | void kvm_irqchip_change_notify(void) | ^ Since nothing in these prototype declarations is target specific, move them around to be generically available, allowing to build kvm-stub.c once for all targets in the next commit. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> Message-Id: <20260309174941.67624-2-philmd@linaro.org>

Philippe Mathieu-Daudé committed Feb 10, 2026 at 15:23 UTC 23e79ed4bfa31bae7bb32eb4edbe8a1ffd3ac776
1 file changed +4 -4
include/system/kvm.h
+4 -4
@@ -219,6 +219,10 @@ int kvm_vm_ioctl(KVMState *s, unsigned long type, ...);
219
220 void kvm_flush_coalesced_mmio_buffer(void);
221
222 +void kvm_irqchip_add_change_notifier(Notifier *n);
223 +void kvm_irqchip_remove_change_notifier(Notifier *n);
224 +void kvm_irqchip_change_notify(void);
225 +
226 #ifdef COMPILING_PER_TARGET
227 #include "cpu.h"
228
@@ -393,10 +397,6 @@ int kvm_irqchip_send_msi(KVMState *s, MSIMessage msg);
397
398 void kvm_irqchip_add_irq_route(KVMState *s, int gsi, int irqchip, int pin);
399
396 -void kvm_irqchip_add_change_notifier(Notifier *n);
397 -void kvm_irqchip_remove_change_notifier(Notifier *n);
398 -void kvm_irqchip_change_notify(void);
399 -
400 struct kvm_guest_debug;
401 struct kvm_debug_exit_arch;
402