@samitouri / QOSamiQemu / commits / 276a6c2919

virtio-gpu: Remove superfluous memory_region_set_enabled()

There is no need to explicitly enable/disable memory region when it's added or deleted respectively. Remove superfluous set_enabled() calls for consistency. Suggested-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp> Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> Message-ID: <20260303151422.977399-15-dmitry.osipenko@collabora.com> Message-ID: <20260304165043.1437519-17-alex.bennee@linaro.org> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Dmitry Osipenko committed Mar 4, 2026 at 16:50 UTC 276a6c2919b75138943a68938e4f677ab2ce8197
1 file changed -2
hw/display/virtio-gpu-virgl.c
-2
@@ -171,7 +171,6 @@ virtio_gpu_virgl_map_resource_blob(VirtIOGPU *g,
171 mr = &vmr->mr;
172 memory_region_init_ram_ptr(mr, OBJECT(vmr), "mr", size, data);
173 memory_region_add_subregion(&b->hostmem, offset, mr);
174 - memory_region_set_enabled(mr, true);
174
175 res->mr = mr;
176
@@ -225,7 +224,6 @@ virtio_gpu_virgl_unmap_resource_blob(VirtIOGPU *g,
224 b->renderer_blocked++;
225
226 /* memory region owns self res->mr object and frees it by itself */
228 - memory_region_set_enabled(mr, false);
227 memory_region_del_subregion(&b->hostmem, mr);
228 object_unparent(OBJECT(vmr));
229 }