target/i386/sev: fix MemoryRegion reference leaks in gpa2hva callers
gpa2hva() returns a referenced MemoryRegion via its p_mr out-parameter (inherited from memory_region_find()), but both SEV callers were failing to release it. Fixes: c7f7e6970d3b ("sev: add sev-inject-launch-secret") Reviewed-by: Peter Xu <peterx@redhat.com> Reviewed-by: Zhao Liu <zhao1.liu@intel.com> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Message-ID: <20260521145451.1831984-1-marcandre.lureau@redhat.com>
Marc-André Lureau committed
May 21, 2026 at 18:54 UTC
415f2759d7b3294e15c783849a08deb26885cabc
2 files changed
+4
-2
include/system/memory.h
+2
@@ -1085,6 +1085,8 @@ void memory_region_ref(MemoryRegion *mr);
1085
*/
1086
void memory_region_unref(MemoryRegion *mr);
1087
1088
+G_DEFINE_AUTOPTR_CLEANUP_FUNC(MemoryRegion, memory_region_unref)
1089
+
1090
/**
1091
* memory_region_init_io: Initialize an I/O memory region.
1092
*
target/i386/sev.c
+2
-2
@@ -1569,7 +1569,7 @@ snp_populate_metadata_pages(SevSnpGuestState *sev_snp,
1569
OvmfSevMetadataDesc *desc;
1570
int type, ret, i;
1571
void *hva;
1572
- MemoryRegion *mr = NULL;
1572
+ g_autoptr(MemoryRegion) mr = NULL;
1573
1574
for (i = 0; i < metadata->num_desc; i++) {
1575
desc = &metadata->descs[i];
@@ -2063,7 +2063,7 @@ int sev_inject_launch_secret(const char *packet_hdr, const char *secret,
2063
int error, ret = 1;
2064
void *hva;
2065
gsize hdr_sz = 0, data_sz = 0;
2066
- MemoryRegion *mr = NULL;
2066
+ g_autoptr(MemoryRegion) mr = NULL;
2067
SevCommonState *sev_common = SEV_COMMON(MACHINE(qdev_get_machine())->cgs);
2068
2069
if (!sev_common) {