@samitouri / QOSamiQemu / commits / 534a96ab74

target/arm/kvm: Don't free migration-blocker reason on failure

The migrate_add_blocker() function documents that if it fails it will free the Error it is passed via its reasonp argument and set reasonp to NULL. That means that in kvm_arm_enable_mte() we don't need to call error_free(mte_migration_blocker) in the failure codepath. Doing so is harmless because error_free(NULL) is permitted and does nothing, but we can remove the unnecessary code. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> Message-id: 20260223173232.453165-1-peter.maydell@linaro.org

Peter Maydell committed Feb 26, 2026 at 11:27 UTC 534a96ab74a91ddcab0f40eff536a17282d3f674
1 file changed -1
target/arm/kvm.c
-1
@@ -2554,7 +2554,6 @@ void kvm_arm_enable_mte(Object *cpuobj, Error **errp)
2554 error_setg(&mte_migration_blocker,
2555 "Live migration disabled due to MTE enabled");
2556 if (migrate_add_blocker(&mte_migration_blocker, errp)) {
2557 - error_free(mte_migration_blocker);
2557 return;
2558 }
2559