@samitouri / QOSamiQemu / commits / 5b881dcc77

hw/misc/aspeed_scu: Drop noisy unhandled read logs for AST2700 SCU/SCUIO

The AST2700 SCU/SCUIO read handlers currently emit LOG_GUEST_ERROR messages for all registers that are not explicitly handled. However, most SCU registers are simple read-back registers without side effects, and do not require explicit handling in the read path. Returning the stored register value is sufficient. Emitting "Unhandled read" logs for these cases generates excessive and misleading noise during normal guest operation, making it harder to spot real issues. Remove the default unhandled read logging from the SCU and SCUIO read handlers to reduce log noise and align with common QEMU device model behavior for passive registers. Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> Reviewed-by: Cédric Le Goater <clg@redhat.com> Link: https://lore.kernel.org/qemu-devel/20260706052701.1141740-3-jamin_lin@aspeedtech.com Signed-off-by: Cédric Le Goater <clg@redhat.com>

Jamin Lin committed Jul 6, 2026 at 05:27 UTC 5b881dcc77c4e54f168c15400efea4fb869c98d3

1 file changed -14

hw/misc/aspeed_scu.c

-14

@@ -849,13 +849,6 @@ static uint64_t aspeed_ast2700_scu_read(void *opaque, hwaddr offset,

849 return 0;

850 }

851

852 - switch (reg) {

853 - default:

854 - qemu_log_mask(LOG_GUEST_ERROR,

855 - "%s: Unhandled read at offset 0x%" HWADDR_PRIx "\n",

856 - __func__, offset);

857 - }

858 -

852 trace_aspeed_ast2700_scu_read(offset, size, s->regs[reg]);

853 return s->regs[reg];

854 }

@@ -961,13 +954,6 @@ static uint64_t aspeed_ast2700_scuio_read(void *opaque, hwaddr offset,

954 return 0;

955 }

956

964 - switch (reg) {

965 - default:

966 - qemu_log_mask(LOG_GUEST_ERROR,

967 - "%s: Unhandled read at offset 0x%" HWADDR_PRIx "\n",

968 - __func__, offset);

969 - }

970 -

957 trace_aspeed_ast2700_scuio_read(offset, size, s->regs[reg]);

958 return s->regs[reg];

959 }