@samitouri / QOSamiQemu / commits / 60405776bf

audio/jack: Fix use of qemu_thread_set_name() on macOS

Since commit 8f68a33ad46 we get on macOS: Audio backends CoreAudio support : YES PipeWire support : NO JACK support : YES 1.9.22 ../audio/jackaudio.c:654:12: error: unused function 'qjack_thread_creator' [-Werror,-Wunused-function] 654 | static int qjack_thread_creator(jack_native_thread_t *thread, | ^~~~~~~~~~~~~~~~~~~~ This is simply due to a missing #ifdef'ry change. Update so we can use the new qemu_thread_set_name() exposed by commit 46255cc2be9. Fixes: 8f68a33ad46 ("audio: make jackaudio use qemu_thread_set_name") Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com> Message-Id: <20260307114923.75394-1-philmd@linaro.org>

Philippe Mathieu-Daudé committed Mar 7, 2026 at 12:37 UTC 60405776bf514769a97ed596ee75f78ebb4f2b05

1 file changed +1 -1

audio/jackaudio.c

+1 -1

@@ -712,7 +712,7 @@ static const TypeInfo audio_types[] = {

712 static void __attribute__((__constructor__)) audio_jack_init(void)

713 {

714 qemu_mutex_init(&qjack_shutdown_lock);

715 -#if !defined(WIN32) && defined(CONFIG_PTHREAD_SETNAME_NP_W_TID)

715 +#if !defined(WIN32)

716 jack_set_thread_creator(qjack_thread_creator);

717 #endif

718 jack_set_error_function(qjack_error);