@samitouri / QOSamiQemu / commits / 64ce9ac187

hw/riscv/riscv-iommu.c: always fault with SADE=0 and A=0

riscv-iommu spec: "If SADE is 1, the IOMMU updates A and D bits in first-stage PTEs atomically. If SADE is 0, the IOMMU causes a page-fault corresponding to the original access type if the A bit is 0 or if the memory access is a store and the D bit is 0.". Note that SADE=0 and A=0 will always cause a fault regardless of the original access type. Right now we're faulting in this case just for reads. Fixes: 0c54acb8243d ("hw/riscv: add RISC-V IOMMU base emulation") Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3551 Signed-off-by: Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com> Acked-by: Alistair Francis <alistair.francis@wdc.com> Reviewed-by: Nutty Liu <nutty.liu@hotmail.com> Message-ID: <20260630211044.82894-1-daniel.barboza@oss.qualcomm.com> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>

Daniel Henrique Barboza committed Jun 30, 2026 at 18:10 UTC 64ce9ac18757d79f3b5b337f7bcbdd0dabef3ce1
1 file changed +1 -1
hw/riscv/riscv-iommu.c
+1 -1
@@ -480,7 +480,7 @@ static int riscv_iommu_spa_fetch(RISCVIOMMUState *s, RISCVIOMMUContext *ctx,
480 break; /* Read access check failed */
481 } else if ((iotlb->perm & IOMMU_WO) && !(pte & PTE_W)) {
482 break; /* Write access check failed */
483 - } else if ((iotlb->perm & IOMMU_RO) && !ade && !(pte & PTE_A)) {
483 + } else if (!ade && !(pte & PTE_A)) {
484 break; /* Access bit not set */
485 } else if ((iotlb->perm & IOMMU_WO) && !ade && !(pte & PTE_D)) {
486 break; /* Dirty bit not set */