@samitouri / QOSamiQemu / commits / 6500a6abe6

tests/qtest/device-plug-test: skip pc tests when 'pc' machine is unavailable

test_pci_unplug_request() and test_pci_unplug_json_request() use "-machine pc" on i386/x86_64. When QEMU is built without the i440fx/pc machine, these fail with "unsupported machine type 'pc'". Skip the x86 case when 'pc' is not available. Non-x86 architectures use the default machine and are unaffected, and x86 unplug coverage is still provided by the q35 variant (test_q35_pci_unplug_request), which already guards on qtest_has_machine("q35"). Signed-off-by: Rohitashv Kumar <roohiit@amazon.de> Signed-off-by: Fabiano Rosas <farosas@suse.de>

Rohitashv Kumar committed Jul 17, 2026 at 08:18 UTC 6500a6abe656743bab51cbff79a6b2c229cd688f
1 file changed +8
tests/qtest/device-plug-test.c
+8
@@ -65,6 +65,10 @@ static void test_pci_unplug_request(void)
65 }
66
67 if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
68 + if (!qtest_has_machine("pc")) {
69 + g_test_skip("Machine 'pc' is not available");
70 + return;
71 + }
72 machine_addition = "-machine pc";
73 }
74
@@ -107,6 +111,10 @@ static void test_pci_unplug_json_request(void)
111 }
112
113 if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
114 + if (!qtest_has_machine("pc")) {
115 + g_test_skip("Machine 'pc' is not available");
116 + return;
117 + }
118 machine_addition = "-machine pc";
119 }
120