@samitouri / QOSamiQemu / commits / 66282b507e

target/arm/ptw: Flip sense of arm_cpu_get_phys_addr return value

Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-id: 20260515142541.571911-13-peter.maydell@linaro.org

Peter Maydell committed May 15, 2026 at 15:25 UTC 66282b507e0eaf2537ec2f035eb9a66788fea92c

1 file changed +4 -9

target/arm/ptw.c

+4 -9

@@ -3965,7 +3965,7 @@ static bool arm_cpu_get_phys_addr(CPUARMState *env, vaddr addr,

3965 result->attrs.debug = 1;

3966 result->lg_page_size = res.f.lg_page_size;

3967 }

3968 - return !ok;

3968 + return ok;

3969 }

3970

3971 bool arm_cpu_translate_for_debug(CPUState *cs, vaddr addr,

@@ -3975,12 +3975,7 @@ bool arm_cpu_translate_for_debug(CPUState *cs, vaddr addr,

3975 CPUARMState *env = &cpu->env;

3976 ARMMMUIdx mmu_idx = arm_mmu_idx(env);

3977

3978 - /*

3979 - * Note that this function returns true on translation success,

3980 - * but arm_cpu_get_phys_addr() and all the other get_phys_addr

3981 - * style functions in this file return true on failure.

3982 - */

3983 - if (!arm_cpu_get_phys_addr(env, addr, result, mmu_idx)) {

3978 + if (arm_cpu_get_phys_addr(env, addr, result, mmu_idx)) {

3979 return true;

3980 }

3981

@@ -3992,10 +3987,10 @@ bool arm_cpu_translate_for_debug(CPUState *cs, vaddr addr,

3987 switch (mmu_idx) {

3988 case ARMMMUIdx_E10_1:

3989 case ARMMMUIdx_E10_1_PAN:

3995 - return !arm_cpu_get_phys_addr(env, addr, result, ARMMMUIdx_E10_0);

3990 + return arm_cpu_get_phys_addr(env, addr, result, ARMMMUIdx_E10_0);

3991 case ARMMMUIdx_E20_2:

3992 case ARMMMUIdx_E20_2_PAN:

3998 - return !arm_cpu_get_phys_addr(env, addr, result, ARMMMUIdx_E20_0);

3993 + return arm_cpu_get_phys_addr(env, addr, result, ARMMMUIdx_E20_0);

3994 default:

3995 /* translation failed */

3996 return false;