accel/whpx: Implement missing AccelClass::gdbstub_supported_sstep_flags
Correct gdbstub support requires some gdbstub_supported_sstep_flags. Apparently missed in commit d7482ffe975 ("whpx: Added support for breakpoints and stepping"), even with the recent 19b48084f71 ("whpx: i386: re-enable guest debug support") fixes. Signed-off-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com> Reviewed-by: Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-ID: <20260705215729.62196-9-philmd@oss.qualcomm.com>
Philippe Mathieu-Daudé committed
Jul 3, 2026 at 15:24 UTC
67ae20cc4ab407d6ce826420be6e838bba99045d
4 files changed
+12
accel/whpx/whpx-common.c
+1
@@ -527,6 +527,7 @@ static void whpx_accel_class_init(ObjectClass *oc, const void *data)
527
ac->init_machine = whpx_accel_init;
528
ac->pre_resume_vm = whpx_pre_resume_vm;
529
ac->allowed = &whpx_allowed;
530
+ ac->gdbstub_supported_sstep_flags = whpx_arch_gdbstub_sstep_flags;
531
532
object_class_property_add(oc, "kernel-irqchip", "on|off|split",
533
NULL, whpx_set_kernel_irqchip,
include/system/whpx-all.h
+1
@@ -23,6 +23,7 @@ void whpx_arch_destroy_vcpu(CPUState *cpu);
23
void whpx_arch_accel_class_init(ObjectClass *oc);
24
25
/* called by whpx-accel-ops */
26
+int whpx_arch_gdbstub_sstep_flags(AccelState *as);
27
bool whpx_arch_supports_guest_debug(void);
28
29
#endif
target/arm/whpx/whpx-all.c
+5
@@ -295,6 +295,11 @@ void whpx_translate_cpu_breakpoints(
295
/* Breakpoints aren’t supported on this platform */
296
}
297
298
+int whpx_arch_gdbstub_sstep_flags(AccelState *as)
299
+{
300
+ return 0;
301
+}
302
+
303
bool whpx_arch_supports_guest_debug(void)
304
{
305
return false;
target/i386/whpx/whpx-all.c
+5
@@ -1853,6 +1853,11 @@ void whpx_apply_breakpoints(
1853
}
1854
}
1855
1856
+int whpx_arch_gdbstub_sstep_flags(AccelState *as)
1857
+{
1858
+ return SSTEP_ENABLE;
1859
+}
1860
+
1861
bool whpx_arch_supports_guest_debug(void)
1862
{
1863
return true;