@samitouri / QOSamiQemu / commits / 6f4544f54d

chardev/char-socket: handle NULL addr in char_socket_get_addr

When called on an unrealized chardev (e.g. from qmp_qom_list_properties), s->addr is NULL. Return an error instead of assert(). Fixes: 123676e9894f ("char-socket: add 'addr' property") Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Marc-André Lureau committed Apr 24, 2026 at 19:04 UTC 6f4544f54d5059f94c66d2417dea3cc7023c4d9a
1 file changed +4
chardev/char-socket.c
+4
@@ -1529,6 +1529,10 @@ char_socket_get_addr(Object *obj, Visitor *v, const char *name,
1529 {
1530 SocketChardev *s = SOCKET_CHARDEV(obj);
1531
1532 + if (!s->addr) {
1533 + error_setg(errp, "socket not connected");
1534 + return;
1535 + }
1536 visit_type_SocketAddress(v, name, &s->addr, errp);
1537 }
1538