@samitouri / QOSamiQemu / commits / 711de639d5

hw/display/vga-pci: Do not expose the 'global-vmstate' property

The "global-vmstate" property is 'false' by default, and was only set to 'true' in the hw_compat_2_12[] array. We removed all machines using that array. Stop exposing that property on the PCI devices. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-ID: <20250501230129.2596-11-philmd@linaro.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com>

Philippe Mathieu-Daudé committed May 2, 2025 at 01:01 UTC 711de639d571b6ac6981020536ff816130768f58
4 files changed -6
hw/display/cirrus_vga.c
-2
@@ -2987,8 +2987,6 @@ static const Property pci_vga_cirrus_properties[] = {
2987 cirrus_vga.vga.vram_size_mb, 4),
2988 DEFINE_PROP_BOOL("blitter", struct PCICirrusVGAState,
2989 cirrus_vga.enable_blitter, true),
2990 - DEFINE_PROP_BOOL("global-vmstate", struct PCICirrusVGAState,
2991 - cirrus_vga.vga.global_vmstate, false),
2990 };
2991
2992 static void cirrus_vga_class_init(ObjectClass *klass, const void *data)
hw/display/qxl.c
-1
@@ -2476,7 +2476,6 @@ static const Property qxl_properties[] = {
2476 DEFINE_PROP_UINT16("max_outputs", PCIQXLDevice, max_outputs, 0),
2477 DEFINE_PROP_UINT32("xres", PCIQXLDevice, xres, 0),
2478 DEFINE_PROP_UINT32("yres", PCIQXLDevice, yres, 0),
2479 - DEFINE_PROP_BOOL("global-vmstate", PCIQXLDevice, vga.global_vmstate, false),
2479 };
2480
2481 static void qxl_pci_class_init(ObjectClass *klass, const void *data)
hw/display/vga-pci.c
-1
@@ -338,7 +338,6 @@ static const Property vga_pci_properties[] = {
338 DEFINE_PROP_BIT("edid",
339 PCIVGAState, flags, PCI_VGA_FLAG_ENABLE_EDID, true),
340 DEFINE_EDID_PROPERTIES(PCIVGAState, edid_info),
341 - DEFINE_PROP_BOOL("global-vmstate", PCIVGAState, vga.global_vmstate, false),
341 };
342
343 static const Property secondary_pci_properties[] = {
hw/display/vmware_vga.c
-2
@@ -1335,8 +1335,6 @@ static void pci_vmsvga_realize(PCIDevice *dev, Error **errp)
1335 static const Property vga_vmware_properties[] = {
1336 DEFINE_PROP_UINT32("vgamem_mb", struct pci_vmsvga_state_s,
1337 chip.vga.vram_size_mb, 16),
1338 - DEFINE_PROP_BOOL("global-vmstate", struct pci_vmsvga_state_s,
1339 - chip.vga.global_vmstate, false),
1338 };
1339
1340 static void vmsvga_class_init(ObjectClass *klass, const void *data)