@samitouri / QOSamiQemu / commits / 7664feb26f

tests/9p: add Txattrcreate / Rxattrcreate test client functions

Add v9fs_txattrcreate() and v9fs_rxattrcreate() functions to the 9P test client for testing creation of xattrs with 9pfs server. Link: https://lore.kernel.org/qemu-devel/5dbc5061dab1f7829fffc40bf89d7ff443e4bcab.1781361555.git.qemu_oss@crudebyte.com Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>

Christian Schoenebeck committed Jun 13, 2026 at 16:55 UTC 7664feb26fef19caa4d72e07a9097fa625b593e5
3 files changed +76
tests/qtest/libqos/virtio-9p-client.c
+45
@@ -243,6 +243,7 @@ static const char *rmessage_name(uint8_t id)
243 id == P9_RREADDIR ? "RREADDIR" :
244 id == P9_RREAD ? "RREAD" :
245 id == P9_RCLUNK ? "RCLUNK" :
246 + id == P9_RXATTRCREATE ? "RXATTRCREATE" :
247 "<unknown>";
248 }
249
@@ -1182,3 +1183,47 @@ void v9fs_rclunk(P9Req *req)
1183 v9fs_req_recv(req, P9_RCLUNK);
1184 v9fs_req_free(req);
1185 }
1186 +
1187 +/* size[4] Txattrcreate tag[2] fid[4] name[s] attr_size[8] flags[4] */
1188 +TXattrCreateRes v9fs_txattrcreate(TXattrCreateOpt opt)
1189 +{
1190 + P9Req *req;
1191 + uint32_t err;
1192 +
1193 + g_assert(opt.client);
1194 + g_assert(opt.name);
1195 +
1196 + uint32_t body_size = 4 + 8 + 4;
1197 + uint16_t string_size = v9fs_string_size(opt.name);
1198 +
1199 + g_assert_cmpint(body_size, <=, UINT32_MAX - string_size);
1200 + body_size += string_size;
1201 +
1202 + req = v9fs_req_init(opt.client, body_size, P9_TXATTRCREATE, opt.tag);
1203 + v9fs_uint32_write(req, opt.fid);
1204 + v9fs_string_write(req, opt.name);
1205 + v9fs_uint64_write(req, opt.size);
1206 + v9fs_uint32_write(req, opt.flags);
1207 + v9fs_req_send(req);
1208 +
1209 + err = 0;
1210 + if (!opt.requestOnly) {
1211 + v9fs_req_wait_for_reply(req, NULL);
1212 + if (opt.expectErr) {
1213 + v9fs_rlerror(req, &err);
1214 + g_assert_cmpint(err, ==, opt.expectErr);
1215 + } else {
1216 + v9fs_rxattrcreate(req);
1217 + }
1218 + req = NULL; /* request was freed */
1219 + }
1220 +
1221 + return (TXattrCreateRes) { .req = req, .err = err };
1222 +}
1223 +
1224 +/* size[4] Rxattrcreate tag[2] */
1225 +void v9fs_rxattrcreate(P9Req *req)
1226 +{
1227 + v9fs_req_recv(req, P9_RXATTRCREATE);
1228 + v9fs_req_free(req);
1229 +}
tests/qtest/libqos/virtio-9p-client.h
+30
@@ -524,6 +524,34 @@ typedef struct TClunkRes {
524 P9Req *req;
525 } TClunkRes;
526
527 +/* options for 'Txattrcreate' 9p request */
528 +typedef struct TXattrCreateOpt {
529 + /* 9P client being used (mandatory) */
530 + QVirtio9P *client;
531 + /* user supplied tag number being returned with response (optional) */
532 + uint16_t tag;
533 + /* file ID to convert to xattr fid (required) */
534 + uint32_t fid;
535 + /* name of the xattr (required) */
536 + const char *name;
537 + /* size of the xattr value (required) */
538 + uint64_t size;
539 + /* flags: P9_XATTR_CREATE or P9_XATTR_REPLACE (optional) */
540 + uint32_t flags;
541 + /* only send Txattrcreate request but not wait for a reply? (optional) */
542 + bool requestOnly;
543 + /* do we expect an Rlerror response, if yes which error code? (optional) */
544 + uint32_t expectErr;
545 +} TXattrCreateOpt;
546 +
547 +/* result of 'Txattrcreate' 9p request */
548 +typedef struct TXattrCreateRes {
549 + /* if requestOnly was set: request object for further processing */
550 + P9Req *req;
551 + /* error code if Rlerror received */
552 + uint32_t err;
553 +} TXattrCreateRes;
554 +
555 void v9fs_set_allocator(QGuestAllocator *t_alloc);
556 void v9fs_memwrite(P9Req *req, const void *addr, size_t len);
557 void v9fs_memskip(P9Req *req, size_t len);
@@ -579,5 +607,7 @@ TReadRes v9fs_tread(TReadOpt opt);
607 void v9fs_rread(P9Req *req, uint32_t *count, void *data);
608 TClunkRes v9fs_tclunk(TClunkOpt opt);
609 void v9fs_rclunk(P9Req *req);
610 +TXattrCreateRes v9fs_txattrcreate(TXattrCreateOpt opt);
611 +void v9fs_rxattrcreate(P9Req *req);
612
613 #endif
tests/qtest/virtio-9p-test.c
+1
@@ -33,6 +33,7 @@
33 #define tunlinkat(...) v9fs_tunlinkat((TunlinkatOpt) __VA_ARGS__)
34 #define tread(...) v9fs_tread((TReadOpt) __VA_ARGS__)
35 #define tclunk(...) v9fs_tclunk((TClunkOpt) __VA_ARGS__)
36 +#define txattrcreate(...) v9fs_txattrcreate((TXattrCreateOpt) __VA_ARGS__)
37
38 static void pci_config(void *obj, void *data, QGuestAllocator *t_alloc)
39 {