@samitouri / QOSamiQemu / commits / 8eaa5b73ab

target/riscv: move debug.h to tcg subdir

riscv_trigger_* APIs are TCG only. Wrap the usages we have of them in cpu.c with CONFIG_TCG. After that we can move the header to the tcg subdir. This will be enough to get this out of the way for the --disable-tcg build. Signed-off-by: Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Message-ID: <20260703180538.3346781-9-daniel.barboza@oss.qualcomm.com> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>

Daniel Henrique Barboza committed Jul 3, 2026 at 15:05 UTC 8eaa5b73ab310610ac33f9d78e801371ea6bafc6
7 files changed +10 -8
target/riscv/cpu.c
+5 -3
@@ -39,7 +39,7 @@
39 #include "kvm/kvm_riscv.h"
40 #include "tcg/tcg-cpu.h"
41 #if !defined(CONFIG_USER_ONLY)
42 -#include "target/riscv/debug.h"
42 +#include "target/riscv/tcg/debug.h"
43 #endif
44
45 /* RISC-V CPU definitions */
@@ -856,9 +856,11 @@ static void riscv_cpu_reset_hold(Object *obj, ResetType type)
856 env->vill = true;
857
858 #ifndef CONFIG_USER_ONLY
859 +#ifdef CONFIG_TCG
860 if (cpu->cfg.debug) {
861 riscv_trigger_reset_hold(env);
862 }
863 +#endif
864
865 if (cpu->cfg.ext_smrnmi) {
866 env->rnmip = 0;
@@ -1016,7 +1018,7 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)
1018
1019 riscv_cpu_register_gdb_regs_for_features(cs);
1020
1019 -#ifndef CONFIG_USER_ONLY
1021 +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY)
1022 if (cpu->cfg.debug) {
1023 riscv_trigger_realize(&cpu->env);
1024 }
@@ -1031,7 +1033,7 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)
1033 static void riscv_cpu_unrealize(DeviceState *dev)
1034 {
1035 RISCVCPUClass *mcc = RISCV_CPU_GET_CLASS(dev);
1034 -#ifndef CONFIG_USER_ONLY
1036 +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY)
1037 RISCVCPU *cpu = RISCV_CPU(dev);
1038
1039 if (cpu->cfg.debug) {
target/riscv/machine.c
+1 -1
@@ -23,7 +23,7 @@
23 #include "system/tcg.h"
24 #include "migration/cpu.h"
25 #include "exec/icount.h"
26 -#include "target/riscv/debug.h"
26 +#include "target/riscv/tcg/debug.h"
27 #include "hw/riscv/machines-qom.h"
28
29 static bool pmp_needed(void *opaque)
target/riscv/tcg/cpu_helper.c
+1 -1
@@ -35,7 +35,7 @@
35 #include "semihosting/common-semi.h"
36 #include "exec/icount.h"
37 #include "cpu_bits.h"
38 -#include "target/riscv/debug.h"
38 +#include "target/riscv/tcg/debug.h"
39 #include "pmp.h"
40 #include "qemu/plugin.h"
41
target/riscv/tcg/csr.c
+1 -1
@@ -34,7 +34,7 @@
34 #include "tcg/insn-start-words.h"
35 #include "internals.h"
36 #if !defined(CONFIG_USER_ONLY)
37 -#include "target/riscv/debug.h"
37 +#include "target/riscv/tcg/debug.h"
38 #endif
39
40 /* CSR function table public API */
target/riscv/tcg/debug.c
+1 -1
@@ -28,7 +28,7 @@
28 #include "qapi/error.h"
29 #include "qemu/error-report.h"
30 #include "cpu.h"
31 -#include "target/riscv/debug.h"
31 +#include "target/riscv/tcg/debug.h"
32 #include "trace.h"
33 #include "exec/helper-proto.h"
34 #include "exec/watchpoint.h"
target/riscv/tcg/debug.h renamed
target/riscv/tcg/tcg-cpu.c
+1 -1
@@ -37,7 +37,7 @@
37 #include "hw/core/boards.h"
38 #include "system/tcg.h"
39 #include "exec/icount.h"
40 -#include "target/riscv/debug.h"
40 +#include "target/riscv/tcg/debug.h"
41 #endif
42
43 /* Hash that stores user set extensions */