ui/vnc-jobs: remove dead VncJobQueue.exit
Since commit 09526058d0a5 ("ui/vnc: Remove vnc_stop_worker_thread()"), it's not used anymore. It seems stopping worker thread hasn't been supported ever. Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Marc-André Lureau committed
Mar 13, 2026 at 23:18 UTC
a74cd53637679fbcc36cb1876bbedd33d5b08337
1 file changed
+2
-8
ui/vnc-jobs.c
+2
-8
@@ -56,7 +56,6 @@ struct VncJobQueue {
56
QemuCond cond;
57
QemuMutex mutex;
58
QemuThread thread;
59
- bool exit;
59
QTAILQ_HEAD(, VncJob) jobs;
60
};
61
@@ -124,7 +123,7 @@ static void vnc_job_free(VncJob *job)
123
void vnc_job_push(VncJob *job)
124
{
125
vnc_lock_queue(queue);
127
- if (queue->exit || QLIST_EMPTY(&job->rectangles)) {
126
+ if (QLIST_EMPTY(&job->rectangles)) {
127
vnc_job_free(job);
128
} else {
129
QTAILQ_INSERT_TAIL(&queue->jobs, job, next);
@@ -248,17 +247,12 @@ static int vnc_worker_thread_loop(VncJobQueue *queue)
247
int saved_offset;
248
249
vnc_lock_queue(queue);
251
- while (QTAILQ_EMPTY(&queue->jobs) && !queue->exit) {
250
+ while (QTAILQ_EMPTY(&queue->jobs)) {
251
qemu_cond_wait(&queue->cond, &queue->mutex);
252
}
254
- /* Here job can only be NULL if queue->exit is true */
253
job = QTAILQ_FIRST(&queue->jobs);
254
vnc_unlock_queue(queue);
255
258
- if (queue->exit) {
259
- return -1;
260
- }
261
-
256
assert(job->vs->magic == VNC_MAGIC);
257
vc = container_of(job->vs, VncConnection, vs);
258