@samitouri / QOSamiQemu / commits / a998be9926

target/i386: emulate: raise an exception on translation fault

Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr> Link: https://lore.kernel.org/r/20260223233950.96076-23-mohamed@unpredictable.fr Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Mohamed Mediouni committed Feb 24, 2026 at 00:39 UTC a998be992651c5ea4165539819f982641c23b6ba
1 file changed +30
target/i386/emulate/x86_mmu.c
+30
@@ -240,8 +240,29 @@ MMUTranslateResult mmu_gva_to_gpa(CPUState *cpu, target_ulong gva, uint64_t *gpa
240 return res;
241 }
242
243 +static int translate_res_to_error_code(MMUTranslateResult res, bool is_write, bool is_user)
244 +{
245 + int error_code = 0;
246 + if (is_user) {
247 + error_code |= PG_ERROR_U_MASK;
248 + }
249 + if (!(res & MMU_TRANSLATE_PAGE_NOT_MAPPED)) {
250 + error_code |= PG_ERROR_P_MASK;
251 + }
252 + if (is_write && (res & MMU_TRANSLATE_PRIV_VIOLATION)) {
253 + error_code |= PG_ERROR_W_MASK;
254 + }
255 + if (res & MMU_TRANSLATE_INVALID_PT_FLAGS) {
256 + error_code |= PG_ERROR_RSVD_MASK;
257 + }
258 + return error_code;
259 +}
260 +
261 static MMUTranslateResult x86_write_mem_ex(CPUState *cpu, void *data, target_ulong gva, int bytes, bool priv_check_exempt)
262 {
263 + X86CPU *x86_cpu = X86_CPU(cpu);
264 + CPUX86State *env = &x86_cpu->env;
265 +
266 MMUTranslateResult translate_res = MMU_TRANSLATE_SUCCESS;
267 MemTxResult mem_tx_res;
268 uint64_t gpa;
@@ -252,6 +273,9 @@ static MMUTranslateResult x86_write_mem_ex(CPUState *cpu, void *data, target_ulo
273
274 translate_res = mmu_gva_to_gpa(cpu, gva, &gpa, MMU_TRANSLATE_VALIDATE_WRITE);
275 if (translate_res) {
276 + int error_code = translate_res_to_error_code(translate_res, true, is_user(cpu));
277 + env->cr[2] = gva;
278 + x86_emul_raise_exception(env, EXCP0E_PAGE, error_code);
279 return translate_res;
280 }
281
@@ -284,6 +308,9 @@ MMUTranslateResult x86_write_mem_priv(CPUState *cpu, void *data, target_ulong gv
308
309 static MMUTranslateResult x86_read_mem_ex(CPUState *cpu, void *data, target_ulong gva, int bytes, bool priv_check_exempt)
310 {
311 + X86CPU *x86_cpu = X86_CPU(cpu);
312 + CPUX86State *env = &x86_cpu->env;
313 +
314 MMUTranslateResult translate_res = MMU_TRANSLATE_SUCCESS;
315 MemTxResult mem_tx_res;
316 uint64_t gpa;
@@ -294,6 +321,9 @@ static MMUTranslateResult x86_read_mem_ex(CPUState *cpu, void *data, target_ulon
321
322 translate_res = mmu_gva_to_gpa(cpu, gva, &gpa, 0);
323 if (translate_res) {
324 + int error_code = translate_res_to_error_code(translate_res, false, is_user(cpu));
325 + env->cr[2] = gva;
326 + x86_emul_raise_exception(env, EXCP0E_PAGE, error_code);
327 return translate_res;
328 }
329 mem_tx_res = address_space_read(&address_space_memory, gpa, MEMTXATTRS_UNSPECIFIED,