qapi: remove user addresses from x-query-virtio-vhost-queue-status
Semantics of these (actually, internal) fields is not simple, they may contain either virtual or physical addresses. We are going to change this to simplify the logic. Keeping this logic only for unstable info command seems too much. Changing semantics of info fields doesn't seem to make real sense too. So, let's just drop them. We can dot it, as command is experimental. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> Acked-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Based-on: <20260206095258.894504-1-vsementsov@yandex-team.ru> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Message-Id: <20260420202032.714884-7-vsementsov@yandex-team.ru>
Vladimir Sementsov-Ogievskiy committed
Apr 20, 2026 at 23:20 UTC
ad865ad765feb322a3f414c480dc57efaf78a529
3 files changed
-21
hw/virtio/virtio-hmp-cmds.c
-3
@@ -203,15 +203,12 @@ void hmp_vhost_queue_status(Monitor *mon, const QDict *qdict)
203
monitor_printf(mon, " call: %"PRId64"\n", s->call);
204
monitor_printf(mon, " VRing:\n");
205
monitor_printf(mon, " num: %"PRId64"\n", s->num);
206
- monitor_printf(mon, " desc: 0x%016"PRIx64"\n", s->desc);
206
monitor_printf(mon, " desc_phys: 0x%016"PRIx64"\n",
207
s->desc_phys);
208
monitor_printf(mon, " desc_size: %"PRId32"\n", s->desc_size);
210
- monitor_printf(mon, " avail: 0x%016"PRIx64"\n", s->avail);
209
monitor_printf(mon, " avail_phys: 0x%016"PRIx64"\n",
210
s->avail_phys);
211
monitor_printf(mon, " avail_size: %"PRId32"\n", s->avail_size);
214
- monitor_printf(mon, " used: 0x%016"PRIx64"\n", s->used);
212
monitor_printf(mon, " used_phys: 0x%016"PRIx64"\n",
213
s->used_phys);
214
monitor_printf(mon, " used_size: %"PRId32"\n", s->used_size);
hw/virtio/virtio-qmp.c
-3
@@ -794,9 +794,6 @@ VirtVhostQueueStatus *qmp_x_query_virtio_vhost_queue_status(const char *path,
794
status->name = g_strdup(vdev->name);
795
status->kick = hdev->vqs[queue].kick;
796
status->call = hdev->vqs[queue].call;
797
- status->desc = (uintptr_t)hdev->vqs[queue].desc;
798
- status->avail = (uintptr_t)hdev->vqs[queue].avail;
799
- status->used = (uintptr_t)hdev->vqs[queue].used;
797
status->num = hdev->vqs[queue].num;
798
status->desc_phys = hdev->vqs[queue].desc_phys;
799
status->desc_size = hdev->vqs[queue].desc_size;
qapi/virtio.json
-15
@@ -650,12 +650,6 @@
650
#
651
# @call: vhost_virtqueue call
652
#
653
-# @desc: vhost_virtqueue desc
654
-#
655
-# @avail: vhost_virtqueue avail
656
-#
657
-# @used: vhost_virtqueue used
658
-#
653
# @num: vhost_virtqueue num
654
#
655
# @desc-phys: vhost_virtqueue desc_phys (descriptor area physical
@@ -678,9 +672,6 @@
672
'data': { 'name': 'str',
673
'kick': 'int',
674
'call': 'int',
681
- 'desc': 'uint64',
682
- 'avail': 'uint64',
683
- 'used': 'uint64',
675
'num': 'int',
676
'desc-phys': 'uint64',
677
'desc-size': 'uint32',
@@ -720,12 +711,9 @@
711
# "avail-size": 2054,
712
# "desc-size": 16384,
713
# "used-size": 8198,
723
-# "desc": 140141447430144,
714
# "num": 1024,
715
# "call": 0,
726
-# "avail": 140141447446528,
716
# "desc-phys": 5216108544,
728
-# "used": 140141447448640,
717
# "kick": 0
718
# }
719
# }
@@ -744,12 +732,9 @@
732
# "avail-size": 262,
733
# "desc-size": 2048,
734
# "used-size": 1030,
747
-# "desc": 140141413580800,
735
# "num": 128,
736
# "call": 0,
750
-# "avail": 140141413582848,
737
# "desc-phys": 5182259200,
752
-# "used": 140141413583168,
738
# "kick": 0
739
# }
740
# }