@samitouri / QOSamiQemu / commits / af4eea83d2

hw/display/cirrus_vga_isa: Disable global_vmstate by default for new machines

In the long run, we would like to get rid of the code that allows to register migration state globally, so set global_vmstate to false when using the isa-cirrus-vga device with new machines, and only enable it for older machines to avoid breaking the migration there. Reviewed-by: Fabiano Rosas <farosas@suse.de> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Signed-off-by: Thomas Huth <thuth@redhat.com> Message-ID: <20260326154850.301609-1-thuth@redhat.com>

Thomas Huth committed Mar 26, 2026 at 16:48 UTC af4eea83d2ba40e065bbc336c794d61f248017b9
2 files changed +3 -1
hw/core/machine.c
+1
@@ -40,6 +40,7 @@
40
41 GlobalProperty hw_compat_10_2[] = {
42 { "scsi-block", "migrate-pr", "off" },
43 + { "isa-cirrus-vga", "global-vmstate", "true" },
44 };
45 const size_t hw_compat_10_2_len = G_N_ELEMENTS(hw_compat_10_2);
46
hw/display/cirrus_vga_isa.c
+2 -1
@@ -56,7 +56,6 @@ static void isa_cirrus_vga_realizefn(DeviceState *dev, Error **errp)
56 s->vram_size_mb);
57 return;
58 }
59 - s->global_vmstate = true;
59 if (!vga_common_init(s, OBJECT(dev), errp)) {
60 return;
61 }
@@ -74,6 +73,8 @@ static const Property isa_cirrus_vga_properties[] = {
73 cirrus_vga.vga.vram_size_mb, 4),
74 DEFINE_PROP_BOOL("blitter", struct ISACirrusVGAState,
75 cirrus_vga.enable_blitter, true),
76 + DEFINE_PROP_BOOL("global-vmstate", struct ISACirrusVGAState,
77 + cirrus_vga.vga.global_vmstate, false),
78 };
79
80 static void isa_cirrus_vga_class_init(ObjectClass *klass, const void *data)