@samitouri / QOSamiQemu / commits / b1173facb5

target/i386/cpu: Remove X86CPU::intel_pt_auto_level field

The X86CPU::intel_pt_auto_level boolean was only set in the pc_compat_3_1[] array, via the 'x-intel-pt-auto-level=off' property. We removed all machines using that array, let's emove that property and all the code around it. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Message-Id: <20260307152635.83893-8-philmd@linaro.org>

Philippe Mathieu-Daudé committed Mar 7, 2026 at 12:55 UTC b1173facb5d3c4abbb91ac5cf53b71dddc002459
2 files changed +1 -12
target/i386/cpu.c
+1 -9
@@ -9565,13 +9565,7 @@ void x86_cpu_expand_features(X86CPU *cpu, Error **errp)
9565
9566 /* Intel Processor Trace requires CPUID[0x14] */
9567 if ((env->features[FEAT_7_0_EBX] & CPUID_7_0_EBX_INTEL_PT)) {
9568 - if (cpu->intel_pt_auto_level) {
9569 - x86_cpu_adjust_level(cpu, &cpu->env.cpuid_min_level, 0x14);
9570 - } else if (cpu->env.cpuid_min_level < 0x14) {
9571 - mark_unavailable_features(cpu, FEAT_7_0_EBX,
9572 - CPUID_7_0_EBX_INTEL_PT,
9573 - "Intel PT need CPUID leaf 0x14, please set by \"-cpu ...,intel-pt=on,min-level=0x14\"");
9574 - }
9568 + x86_cpu_adjust_level(cpu, &cpu->env.cpuid_min_level, 0x14);
9569 }
9570
9571 /*
@@ -10589,8 +10583,6 @@ static const Property x86_cpu_properties[] = {
10583 * to the specific Windows version being used."
10584 */
10585 DEFINE_PROP_INT32("x-hv-max-vps", X86CPU, hv_max_vps, -1),
10592 - DEFINE_PROP_BOOL("x-intel-pt-auto-level", X86CPU, intel_pt_auto_level,
10593 - true),
10586 DEFINE_PROP_BOOL("x-l1-cache-per-thread", X86CPU, l1_cache_per_core, true),
10587 DEFINE_PROP_BOOL("x-force-cpuid-0x1f", X86CPU, force_cpuid_0x1f, false),
10588
target/i386/cpu.h
-3
@@ -2457,9 +2457,6 @@ struct ArchCPU {
2457 /* Only advertise TOPOEXT features that AMD defines */
2458 bool amd_topoext_features_only;
2459
2460 - /* Enable auto level-increase for Intel Processor Trace leave */
2461 - bool intel_pt_auto_level;
2462 -
2460 /* if true fill the top bits of the MTRR_PHYSMASKn variable range */
2461 bool fill_mtrr_mask;
2462