@samitouri / QOSamiQemu / commits / c2fd17ec64

target/mips: add Octeon CvmCount RDHWR support

Octeon exposes CvmCount through RDHWR register 31. Add the Octeon-only decode path, enable the corresponding HWREna bit for linux-user, and use an unsigned mask when checking HWREna so bit 31 is handled safely. For user-mode emulation, return host ticks as a monotonic counter source suitable for existing Octeon userspace code. In system mode, fall back to the existing CP0 Count value. Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Signed-off-by: James Hilliard <james.hilliard1@gmail.com> Message-ID: <20260608-mips-octeon-missing-insns-v2-v16-20-daef7a0d8b04@gmail.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>

James Hilliard committed Jun 8, 2026 at 12:59 UTC c2fd17ec64451d3aa181623e056ca1ce019eddcd
5 files changed +42 -1
target/mips/cpu.c
+1
@@ -320,6 +320,7 @@ static void mips_cpu_reset_hold(Object *obj, ResetType type)
320 env->CP0_HWREna |= 0x0000000F;
321 if (env->insn_flags & INSN_OCTEON) {
322 env->CP0_HWREna |= 0x40000000u;
323 + env->CP0_HWREna |= 0x80000000u;
324 }
325 if (env->CP0_Config1 & (1 << CP0C1_FP)) {
326 env->CP0_Status |= (1 << CP0St_CU1);
target/mips/helper.h
+1
@@ -255,6 +255,7 @@ DEF_HELPER_1(rdhwr_ccres, tl, env)
255 DEF_HELPER_1(rdhwr_performance, tl, env)
256 DEF_HELPER_1(rdhwr_xnp, tl, env)
257 DEF_HELPER_1(rdhwr_chord, tl, env)
258 +DEF_HELPER_1(rdhwr_cvmcount, tl, env)
259 DEF_HELPER_2(pmon, void, env, int)
260 DEF_HELPER_1(wait, void, env)
261
target/mips/tcg/op_helper.c
+12 -1
@@ -25,6 +25,7 @@
25 #include "exec/memop.h"
26 #include "fpu_helper.h"
27 #include "qemu/crc32c.h"
28 +#include "qemu/timer.h"
29 #include <zlib.h>
30
31 static inline target_ulong bitswap(target_ulong v)
@@ -209,7 +210,7 @@ target_ulong helper_yield(CPUMIPSState *env, target_ulong arg)
210
211 static inline void check_hwrena(CPUMIPSState *env, int reg, uintptr_t pc)
212 {
212 - if ((env->hflags & MIPS_HFLAG_CP0) || (env->CP0_HWREna & (1 << reg))) {
213 + if ((env->hflags & MIPS_HFLAG_CP0) || (env->CP0_HWREna & (1u << reg))) {
214 return;
215 }
216 do_raise_exception(env, EXCP_RI, pc);
@@ -261,6 +262,16 @@ target_ulong helper_rdhwr_chord(CPUMIPSState *env)
262 return env->octeon_crypto.chord;
263 }
264
265 +target_ulong helper_rdhwr_cvmcount(CPUMIPSState *env)
266 +{
267 + check_hwrena(env, 31, GETPC());
268 +#ifdef CONFIG_USER_ONLY
269 + return cpu_get_host_ticks();
270 +#else
271 + return (uint32_t)cpu_mips_get_count(env);
272 +#endif
273 +}
274 +
275 void helper_pmon(CPUMIPSState *env, int function)
276 {
277 function /= 2;
target/mips/tcg/translate.c
+11
@@ -10933,6 +10933,17 @@ void gen_rdhwr(DisasContext *ctx, int rt, int rd, int sel)
10933 gen_helper_rdhwr_chord(t0, tcg_env);
10934 gen_store_gpr(t0, rt);
10935 break;
10936 + case 31:
10937 + if (!(ctx->insn_flags & INSN_OCTEON)) {
10938 + gen_reserved_instruction(ctx);
10939 + break;
10940 + }
10941 + translator_io_start(&ctx->base);
10942 + gen_helper_rdhwr_cvmcount(t0, tcg_env);
10943 + gen_store_gpr(t0, rt);
10944 + gen_save_pc(ctx->base.pc_next + 4);
10945 + ctx->base.is_jmp = DISAS_EXIT;
10946 + break;
10947 default: /* Invalid */
10948 MIPS_INVAL("rdhwr");
10949 gen_reserved_instruction(ctx);
tests/tcg/mips/user/isa/octeon/octeon-insns.c
+17
@@ -330,6 +330,22 @@ static uint64_t octeon_cop2_gfm_mul_reflect_readback(uint64_t value)
330 return rd;
331 }
332
333 +static uint64_t octeon_rdhwr31_non_decreasing(void)
334 +{
335 + uint64_t first, second;
336 +
337 + asm volatile(
338 + ".word 0x7c08f83b\n\t" /* rdhwr $8, $31 */
339 + ".word 0x7c09f83b\n\t" /* rdhwr $9, $31 */
340 + "move %[first], $8\n\t"
341 + "move %[second], $9\n\t"
342 + : [first] "=r" (first), [second] "=r" (second)
343 + :
344 + : "$8", "$9");
345 +
346 + return second >= first;
347 +}
348 +
349 int main(void)
350 {
351 assert(octeon_baddu(0x123, 0x0f0) == 0x13);
@@ -358,6 +374,7 @@ int main(void)
374 0x0123456789abcdefULL) == 0xf7b3d591e6a2c480ULL);
375 assert(octeon_cop2_gfm_mul_reflect_readback(
376 0xfedcba9876543210ULL) == 0x084c2a6e195d3b7fULL);
377 + assert(octeon_rdhwr31_non_decreasing());
378
379 return 0;
380 }