tests/functional/qemu_test: drop *args argument from .get_vm()
It's redundant. Only one caller use it, and it may be simply substituted by .add_args(). Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> Reviewed-by: Thomas Huth <thuth@redhat.com> Message-ID: <20260729093146.1893719-3-vsementsov@yandex-team.ru> Signed-off-by: Thomas Huth <thuth@redhat.com>
Vladimir Sementsov-Ogievskiy committed
Jul 29, 2026 at 12:31 UTC
c347711ea7f5b9cbcd558ecfaa81988e0baff359
2 files changed
+5
-7
tests/functional/migration.py
+2
-1
@@ -63,7 +63,8 @@ class MigrationTest(QemuSystemTest):
63
self.assert_dest_vm(dst_vm)
64
65
def migrate(self, dst_uri, src_uri=None):
66
- dst_vm = self.get_vm('-incoming', 'defer', name="dst-qemu")
66
+ dst_vm = self.get_vm("dst-qemu")
67
+ dst_vm.add_args('-incoming', 'defer')
68
self.configure_machine(dst_vm)
69
dst_vm.launch()
70
tests/functional/qemu_test/testcase.py
+3
-6
@@ -381,7 +381,7 @@ class QemuSystemTest(QemuBaseTest):
381
if helptxt.find(devicename) < 0:
382
self.skipTest('no support for device ' + devicename)
383
384
- def _new_vm(self, name, *args):
384
+ def _new_vm(self, name):
385
vm = QEMUMachine(self.qemu_bin,
386
name=name,
387
base_temp_dir=self.workdir,
@@ -394,20 +394,17 @@ class QemuSystemTest(QemuBaseTest):
394
vm.add_args("-chardev",
395
f"socket,id=backdoor,path={sockpath},server=on,wait=off",
396
"-mon", "chardev=backdoor,mode=control")
397
-
398
- if args:
399
- vm.add_args(*args)
397
return vm
398
399
@property
400
def vm(self):
401
return self.get_vm(name='default')
402
406
- def get_vm(self, *args, name=None):
403
+ def get_vm(self, name=None):
404
if not name:
405
name = str(uuid.uuid4())
406
if self._vms.get(name) is None:
410
- self._vms[name] = self._new_vm(name, *args)
407
+ self._vms[name] = self._new_vm(name)
408
if self.cpu is not None:
409
self._vms[name].add_args('-cpu', self.cpu)
410
if self.machine is not None: