@samitouri / QOSamiQemu / commits / cbf8e38203

hw/sparc/sun4m: Don't set up dummy cpu interrupts

In the sun4m machine init, we set up the cpu_irqs[] array with the real inbound IRQs for each CPU, followed by some dummy IRQs for the remaining slots from smp_cpus up to MAX_CPUS. These dummy IRQs do nothing when set/cleared because the dummy_cpu_set_irq() function does nothing. Instead of creating these "do nothing" qemu_irqs, instead pass the number of CPUs to slavio_intctl_init() so that it can only wire up the interrupt controller's interrupts for the CPUs that actually exist. Calling qemu_set_irq() on an irq that isn't connected does nothing, so this is a simpler way to achieve the same result. This cleanup fixes an unimportant memory leak reported by the address sanitizer that happens because we allocate these dummy IRQs with qemu_allocate_irqs(): Direct leak of 1920 byte(s) in 15 object(s) allocated from: #0 0x5cb7b120cf63 in malloc (/home/pm215/qemu/build/san/qemu-system-sparc+0xe0bf63) (BuildId: d27f9230a7cc82ebfaf0cf9e439dc215ddd7ac68) #1 0x743cd6dc5ac9 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x62ac9) (BuildId: 116e142b9b52c8a4dfd403e759e71ab8f95d8bb3) #2 0x5cb7b1a42fb4 in qemu_extend_irqs /home/pm215/qemu/build/san/../../hw/core/irq.c:77:51 #3 0x5cb7b19e7e72 in sun4m_hw_init /home/pm215/qemu/build/san/../../hw/sparc/sun4m.c:845:23 #4 0x5cb7b141d3dd in machine_run_board_init /home/pm215/qemu/build/san/../../hw/core/machine.c:1709:5 #5 0x5cb7b1542895 in qemu_init_board /home/pm215/qemu/build/san/../../system/vl.c:2717:5 #6 0x5cb7b1542895 in qmp_x_exit_preconfig /home/pm215/qemu/build/san/../../system/vl.c:2811:5 #7 0x5cb7b15493ac in qemu_init /home/pm215/qemu/build/san/../../system/vl.c:3849:9 #8 0x5cb7b1f3f201 in main /home/pm215/qemu/build/san/../../system/main.c:71:5 #9 0x743cd4a2a1c9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #10 0x743cd4a2a28a in __libc_start_main csu/../csu/libc-start.c:360:3 #11 0x5cb7b1172114 in _start (/home/pm215/qemu/build/san/qemu-system-sparc+0xd71114) (BuildId: d27f9230a7cc82ebfaf0cf9e439dc215ddd7ac68) Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Message-ID: <20260307112931.3322532-2-peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Peter Maydell committed Mar 7, 2026 at 11:29 UTC cbf8e382039cd17e296f5729f301ad26eb0bd1d5
1 file changed +3 -8
hw/sparc/sun4m.c
+3 -8
@@ -196,10 +196,6 @@ static void cpu_set_irq(void *opaque, int irq, int level)
196 }
197 }
198
199 -static void dummy_cpu_set_irq(void *opaque, int irq, int level)
200 -{
201 -}
202 -
199 static void sun4m_cpu_reset(void *opaque)
200 {
201 SPARCCPU *cpu = opaque;
@@ -344,6 +340,7 @@ static void *sparc32_dma_init(hwaddr dma_base,
340
341 static DeviceState *slavio_intctl_init(hwaddr addr,
342 hwaddr addrg,
343 + unsigned int smp_cpus,
344 qemu_irq **parent_irq)
345 {
346 DeviceState *dev;
@@ -355,7 +352,7 @@ static DeviceState *slavio_intctl_init(hwaddr addr,
352 s = SYS_BUS_DEVICE(dev);
353 sysbus_realize_and_unref(s, &error_fatal);
354
358 - for (i = 0; i < MAX_CPUS; i++) {
355 + for (i = 0; i < smp_cpus; i++) {
356 for (j = 0; j < MAX_PILS; j++) {
357 sysbus_connect_irq(s, i * MAX_PILS + j, parent_irq[i][j]);
358 }
@@ -841,9 +838,6 @@ static void sun4m_hw_init(MachineState *machine)
838 cpu_devinit(machine->cpu_type, i, hwdef->slavio_base, &cpu_irqs[i]);
839 }
840
844 - for (i = smp_cpus; i < MAX_CPUS; i++)
845 - cpu_irqs[i] = qemu_allocate_irqs(dummy_cpu_set_irq, NULL, MAX_PILS);
846 -
841 /* Create and map RAM frontend */
842 dev = qdev_new("memory");
843 object_property_set_link(OBJECT(dev), "memdev", OBJECT(ram_memdev), &error_fatal);
@@ -860,6 +854,7 @@ static void sun4m_hw_init(MachineState *machine)
854
855 slavio_intctl = slavio_intctl_init(hwdef->intctl_base,
856 hwdef->intctl_base + 0x10000ULL,
857 + smp_cpus,
858 cpu_irqs);
859
860 for (i = 0; i < 32; i++) {