plugins/api-system: Handle migrate_add_blocker() failure
migrate_add_blocker() can fail (e.g. if migration is already in progress), in which case it returns a negative value and populates its errp argument with the reason. The previous code ignored the return value. Pass &error_fatal so that on failure QEMU exits cleanly with an informative error message rather than continuing in an inconsistent state. Resolves: CID 1645470 Signed-off-by: Trieu Huynh <vikingtc4@gmail.com> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> Tested-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> Link: https://lore.kernel.org/qemu-devel/20260317134733.126584-1-vikingtc4@gmail.com Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Trieu Huynh committed
Mar 17, 2026 at 22:47 UTC
db52193355cf75394a39ca9f70b1325d4bbe18d6
1 file changed
+1
-1
plugins/api-system.c
+1
-1
@@ -108,7 +108,7 @@ const void *qemu_plugin_request_time_control(void)
108
has_control = true;
109
error_setg(&migration_blocker,
110
"TCG plugin time control does not support migration");
111
- migrate_add_blocker(&migration_blocker, NULL);
111
+ migrate_add_blocker(&migration_blocker, &error_fatal);
112
return &has_control;
113
}
114
return NULL;