@samitouri / QOSamiQemu / commits / e883c338dd

monitor: Include missing 'qemu/lockable.h' header

Files in monitor/ use the QEMU_LOCK_GUARD() macros, which are declared in "qemu/lockable.h". Include the latter to avoid when refactoring unrelated headers: ../monitor/fds.c:146:5: error: call to undeclared function 'QEMU_LOCK_GUARD' 146 | QEMU_LOCK_GUARD(&mon->mon_lock); | ^ ../monitor/monitor.c:176:5: error: call to undeclared function 'QEMU_LOCK_GUARD' 176 | QEMU_LOCK_GUARD(&mon->mon_lock); | ^ ../monitor/qmp.c:164:5: error: call to undeclared function 'WITH_QEMU_LOCK_GUARD' 164 | WITH_QEMU_LOCK_GUARD(&mon->mon_lock) { | ^ Fixes: 0210c3b39be ("monitor: Use LOCK_GUARD macros") Signed-off-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Message-Id: <20260812211708.92824-9-philmd@oss.qualcomm.com>

Philippe Mathieu-Daudé committed Aug 12, 2026 at 11:10 UTC e883c338dd1997a4e06a5f3be8ea53310b3a44ce

3 files changed +3

monitor/fds.c

@@ -29,6 +29,7 @@

29 #include "qapi/qmp/qerror.h"

30 #include "qemu/ctype.h"

31 #include "qemu/cutils.h"

32 +#include "qemu/lockable.h"

33 #include "system/runstate.h"

35 /* file descriptors passed via SCM_RIGHTS */

monitor/monitor.c

@@ -32,6 +32,7 @@

32 #include "qom/object_interfaces.h"

33 #include "qemu/aio-wait.h"

34 #include "qemu/error-report.h"

35 +#include "qemu/lockable.h"

36 #include "qemu/option.h"

37 #include "system/qtest.h"

38 #include "trace.h"

monitor/qmp.c

@@ -24,6 +24,7 @@

25 #include "qemu/osdep.h"

26 #include "qemu/aio-wait.h"

27 +#include "qemu/lockable.h"

28 #include "chardev/char-io.h"

29 #include "monitor-internal.h"

30 #include "qapi/error.h"