@samitouri / QOSamiQemu / commits / ec931476cd

target/mips: decode Octeon block-cipher COP2 selectors

Add explicit decodetree entries and translator bindings for the Octeon AES, SMS4, 3DES, KASUMI, and Camellia COP2 operation selectors. These selectors consume or update engine state, so keep them as per-operation helper calls while the simple block-cipher register moves remain direct TCG loads and stores from the earlier register-selector patch. This completes the block-cipher selector coverage without reintroducing a generic runtime selector dispatch path. Signed-off-by: James Hilliard <james.hilliard1@gmail.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-ID: <20260608-mips-octeon-missing-insns-v2-v16-18-daef7a0d8b04@gmail.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>

James Hilliard committed Jun 8, 2026 at 12:59 UTC ec931476cdf98909e54811620f53d5337a19058f
2 files changed +34
target/mips/tcg/octeon.decode
+17
@@ -203,6 +203,8 @@ LDX 011111 ..... ..... ..... 01000 001010 @lx
203 CVM_MT_AES_DEC_CBC0 010010 00101 rt:5 0000 0001 0000 1100 &cp2
204 CVM_MT_AES_DEC0 010010 00101 rt:5 0000 0001 0000 1110 &cp2
205 CVM_MT_AES_KEYLENGTH 010010 00101 rt:5 0000 0001 0001 0000 &cp2
206 + CVM_MT_CAMELLIA_FL 010010 00101 rt:5 0000 0001 0001 0101 &cp2
207 + CVM_MT_CAMELLIA_FLINV 010010 00101 rt:5 0000 0001 0001 0110 &cp2
208 CVM_MT_CRC_IV 010010 00101 rt:5 0000 0010 0000 0001 &cp2
209 CVM_MT_CRC_IV_REFLECT 010010 00101 rt:5 0000 0010 0001 0001 &cp2
210 CVM_MT_CRC_BYTE 010010 00101 rt:5 0000 0010 0000 0100 &cp2
@@ -264,6 +266,15 @@ LDX 011111 ..... ..... ..... 01000 001010 @lx
266 CVM_MT_CRC_VAR 010010 00101 rt:5 0001 0010 0000 1000 &cp2
267 CVM_MT_CRC_DWORD_REFLECT 010010 00101 rt:5 0001 0010 0001 0111 &cp2
268 CVM_MT_CRC_VAR_REFLECT 010010 00101 rt:5 0001 0010 0001 1000 &cp2
269 + CVM_MT_AES_ENC_CBC1 010010 00101 rt:5 0011 0001 0000 1001 &cp2
270 + CVM_MT_AES_ENC1 010010 00101 rt:5 0011 0001 0000 1011 &cp2
271 + CVM_MT_AES_DEC_CBC1 010010 00101 rt:5 0011 0001 0000 1101 &cp2
272 + CVM_MT_AES_DEC1 010010 00101 rt:5 0011 0001 0000 1111 &cp2
273 + CVM_MT_CAMELLIA_ROUND 010010 00101 rt:5 0011 0001 0001 0100 &cp2
274 + CVM_MT_SMS4_ENC_CBC1 010010 00101 rt:5 0011 0001 0001 1001 &cp2
275 + CVM_MT_SMS4_ENC1 010010 00101 rt:5 0011 0001 0001 1011 &cp2
276 + CVM_MT_SMS4_DEC_CBC1 010010 00101 rt:5 0011 0001 0001 1101 &cp2
277 + CVM_MT_SMS4_DEC1 010010 00101 rt:5 0011 0001 0001 1111 &cp2
278 CVM_MT_HSH_STARTMD5 010010 00101 rt:5 0100 0000 0100 0111 &cp2
279 CVM_MT_SNOW3G_START 010010 00101 rt:5 0100 0000 0100 1101 &cp2
280 CVM_MT_SNOW3G_MORE 010010 00101 rt:5 0100 0000 0100 1110 &cp2
@@ -273,6 +284,12 @@ LDX 011111 ..... ..... ..... 01000 001010 @lx
284 CVM_MT_ZUC_MORE 010010 00101 rt:5 0100 0000 0101 0110 &cp2
285 CVM_MT_HSH_STARTSHA 010010 00101 rt:5 0100 0000 0101 0111 &cp2
286 CVM_MT_GFM_XORMUL1_REFLECT 010010 00101 rt:5 0100 0000 0101 1101 &cp2
287 + CVM_MT_3DES_ENC_CBC 010010 00101 rt:5 0100 0000 1000 1000 &cp2
288 + CVM_MT_KAS_ENC_CBC 010010 00101 rt:5 0100 0000 1000 1001 &cp2
289 + CVM_MT_3DES_ENC 010010 00101 rt:5 0100 0000 1000 1010 &cp2
290 + CVM_MT_KAS_ENC 010010 00101 rt:5 0100 0000 1000 1011 &cp2
291 + CVM_MT_3DES_DEC_CBC 010010 00101 rt:5 0100 0000 1000 1100 &cp2
292 + CVM_MT_3DES_DEC 010010 00101 rt:5 0100 0000 1000 1110 &cp2
293 CVM_MT_CRC_POLYNOMIAL 010010 00101 rt:5 0100 0010 0000 0000 &cp2
294 CVM_MT_CRC_POLYNOMIAL_REFLECT 010010 00101 rt:5 0100 0010 0001 0000 &cp2
295 CVM_MT_HSH_STARTSHA512 010010 00101 rt:5 0100 0010 0100 1111 &cp2
target/mips/tcg/octeon_translate.c
+17
@@ -349,6 +349,23 @@ CP2_MT_HELPER(CVM_MT_ZUC_START, zuc_start);
349 CP2_MT_HELPER(CVM_MT_ZUC_MORE, zuc_more);
350 CP2_MT_HELPER(CVM_MT_SNOW3G_START, snow3g_start);
351 CP2_MT_HELPER(CVM_MT_SNOW3G_MORE, snow3g_more);
352 +CP2_MT_HELPER(CVM_MT_AES_ENC_CBC1, aes_enc_cbc1);
353 +CP2_MT_HELPER(CVM_MT_AES_ENC1, aes_enc1);
354 +CP2_MT_HELPER(CVM_MT_AES_DEC_CBC1, aes_dec_cbc1);
355 +CP2_MT_HELPER(CVM_MT_AES_DEC1, aes_dec1);
356 +CP2_MT_HELPER(CVM_MT_SMS4_ENC_CBC1, sms4_enc_cbc1);
357 +CP2_MT_HELPER(CVM_MT_SMS4_ENC1, sms4_enc1);
358 +CP2_MT_HELPER(CVM_MT_SMS4_DEC_CBC1, sms4_dec_cbc1);
359 +CP2_MT_HELPER(CVM_MT_SMS4_DEC1, sms4_dec1);
360 +CP2_MT_HELPER(CVM_MT_3DES_ENC_CBC, des3_enc_cbc);
361 +CP2_MT_HELPER(CVM_MT_KAS_ENC_CBC, kas_enc_cbc);
362 +CP2_MT_HELPER(CVM_MT_3DES_ENC, des3_enc);
363 +CP2_MT_HELPER(CVM_MT_KAS_ENC, kas_enc);
364 +CP2_MT_HELPER(CVM_MT_3DES_DEC_CBC, des3_dec_cbc);
365 +CP2_MT_HELPER(CVM_MT_3DES_DEC, des3_dec);
366 +CP2_MT_HELPER(CVM_MT_CAMELLIA_FL, camellia_fl);
367 +CP2_MT_HELPER(CVM_MT_CAMELLIA_FLINV, camellia_flinv);
368 +CP2_MT_HELPER(CVM_MT_CAMELLIA_ROUND, camellia_round);
369 CP2_MT_HELPER(CVM_MT_HSH_STARTSHA1_COMPAT, hsh_startsha1_compat);
370 CP2_MT_I64(CVM_MT_HSH_DATW0, hsh_dat[0]);
371 CP2_MT_I64(CVM_MT_HSH_DATW1, hsh_dat[1]);