@samitouri / QOSamiQemu / commits / ee5b216c0e

target/i386: emulate: remove redundant logging for unmapped MMIO access

ReactOS's install ISO does a bunch of 4-byte accesses to 0xffdff124. This doesn't happen for the boot ISO. It looks to be an access relative to the Windows KPCR which is at 0xffdff000 but mistakenly done prior to paging being on... As this logging is redundant with -d invalid_mem, remove it. https://geoffchappell.com/studies/windows/km/ntoskrnl/inc/ntos/i386_x/kpcr.htm Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr> Link: https://lore.kernel.org/r/20260327011152.4126-5-mohamed@unpredictable.fr Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Mohamed Mediouni committed Mar 27, 2026 at 02:11 UTC ee5b216c0eb368d20114c6ff696ad637dbfb98c2
1 file changed -3
target/i386/emulate/x86_mmu.c
-3
@@ -21,7 +21,6 @@
21 #include "cpu.h"
22 #include "system/address-spaces.h"
23 #include "system/memory.h"
24 -#include "qemu/error-report.h"
24 #include "emulate/x86.h"
25 #include "emulate/x86_emu.h"
26 #include "emulate/x86_mmu.h"
@@ -287,7 +286,6 @@ static MMUTranslateResult x86_write_mem_ex(CPUState *cpu, void *data, target_ulo
286 MEMTXATTRS_UNSPECIFIED, data, copy);
287
288 if (mem_tx_res == MEMTX_DECODE_ERROR) {
290 - warn_report("write to unmapped mmio region gpa=0x%" PRIx64 " size=%i", gpa, bytes);
289 return MMU_TRANSLATE_GPA_UNMAPPED;
290 } else if (mem_tx_res == MEMTX_ACCESS_ERROR) {
291 return MMU_TRANSLATE_GPA_NO_WRITE_ACCESS;
@@ -339,7 +337,6 @@ static MMUTranslateResult x86_read_mem_ex(CPUState *cpu, void *data, target_ulon
337 data, copy);
338
339 if (mem_tx_res == MEMTX_DECODE_ERROR) {
342 - warn_report("read from unmapped mmio region gpa=0x%" PRIx64 " size=%i", gpa, bytes);
340 return MMU_TRANSLATE_GPA_UNMAPPED;
341 } else if (mem_tx_res == MEMTX_ACCESS_ERROR) {
342 return MMU_TRANSLATE_GPA_NO_READ_ACCESS;