hw/tpm: Refactor CRB_CTRL_START register access
Replace manual bitwise operations with ARRAY_FIELD_DP32 macros No functional changes. Signed-off-by: Arun Menon <armenon@redhat.com> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Link: https://lore.kernel.org/qemu-devel/20260506075813.120781-3-armenon@redhat.com Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Arun Menon committed
May 6, 2026 at 13:28 UTC
fccc36bb31eb907dea944099828fc13649a8dc63
1 file changed
+2
-2
hw/tpm/tpm_crb.c
+2
-2
@@ -146,7 +146,7 @@ static void tpm_crb_mmio_write(void *opaque, hwaddr addr,
146
tpm_crb_get_active_locty(s) == locty) {
147
void *mem = memory_region_get_ram_ptr(&s->cmdmem);
148
149
- s->regs[R_CRB_CTRL_START] |= CRB_START_INVOKE;
149
+ ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, Start, 1);
150
s->cmd = (TPMBackendCmd) {
151
.in = mem,
152
.in_len = MIN(tpm_cmd_get_size(mem), s->be_buffer_size),
@@ -195,7 +195,7 @@ static void tpm_crb_request_completed(TPMIf *ti, int ret)
195
{
196
CRBState *s = CRB(ti);
197
198
- s->regs[R_CRB_CTRL_START] &= ~CRB_START_INVOKE;
198
+ ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, Start, 0);
199
if (ret != 0) {
200
ARRAY_FIELD_DP32(s->regs, CRB_CTRL_STS,
201
tpmSts, 1); /* fatal error */