fix(onboarding): await modal close before presets
er-s-an committed
Aug 14, 2026 at 02:56 UTC
be2561b789a6b9fb248cdd567939302951c667a1
2 files changed
+15
-1
plugins/_onboarding/webui/onboarding-store.js
+1
-1
@@ -859,7 +859,7 @@ export const store = createStore("onboarding", {
859
},
860
861
async openAdvancedSettings() {
862
- window.closeModal?.();
862
+ await window.closeModal?.();
863
await modelConfigStore.openPresetEditor(
864
this.config?.model_preset || "Default"
865
);
tests/test_onboarding_static.py
+14
@@ -80,6 +80,20 @@ def test_onboarding_contains_unified_provider_step():
80
assert "localGuidance()" in html + store
81
82
83
+def test_onboarding_closes_before_opening_advanced_model_settings():
84
+ store = (PROJECT_ROOT / "plugins/_onboarding/webui/onboarding-store.js").read_text(
85
+ encoding="utf-8"
86
+ )
87
+ method = store.split(" async openAdvancedSettings() {", 1)[1].split("\n },", 1)[0]
88
+
89
+ close_call = "await window.closeModal?.();"
90
+ open_call = "await modelConfigStore.openPresetEditor("
91
+
92
+ assert close_call in method
93
+ assert open_call in method
94
+ assert method.index(close_call) < method.index(open_call)
95
+
96
+
97
def test_onboarding_provider_grid_names_are_present_in_metadata():
98
provider_yaml = (PROJECT_ROOT / "conf/model_providers.yaml").read_text(encoding="utf-8")
99
provider_ui = (PROJECT_ROOT / "plugins/_onboarding/webui/onboarding-providers.js").read_text(encoding="utf-8")