@smbcloud / cli / commits / 9c849d8

Move secrets to step

Seto Elkahfi committed Apr 7, 2023 at 20:56 UTC 9c849d8e88efeb3b37ef286cb28d71b10772dc98
2 files changed +7 -6
.github/workflows/release-npm.yml
+3 -3
@@ -8,9 +8,6 @@ on:
8 jobs:
9 publish-npm-binaries:
10 name: Publish NPM packages
11 - env:
12 - GH_OAUTH_CLIENT_ID: ${{ secrets.GH_OAUTH_CLIENT_ID }}
13 - GH_OAUTH_CLIENT_SECRET: ${{ secrets.GH_OAUTH_CLIENT_SECRET }}
11 runs-on: ${{ matrix.build.os }}
12 strategy:
13 fail-fast: false
@@ -68,6 +65,9 @@ jobs:
65 toolchain: ${{ matrix.build.TOOLCHAIN}}
66
67 - name: Build
68 + env:
69 + GH_OAUTH_CLIENT_ID: ${{ secrets.GH_OAUTH_CLIENT_ID }}
70 + GH_OAUTH_CLIENT_SECRET: ${{ secrets.GH_OAUTH_CLIENT_SECRET }}
71 shell: bash
72 run: cargo build --release --locked --target ${{ matrix.build.TARGET }}
73
src/account/signup/process.rs
+4 -3
@@ -288,9 +288,10 @@ fn select_github_emails(github_emails: Vec<GithubEmail>) -> Result<GithubEmail>
288 }
289
290 fn github_url_builder() -> URLBuilder {
291 - let client_id = dotenv::var("GH_OAUTH_CLIENT_ID").unwrap_or("development".to_owned());
292 - let redirect_uri =
293 - dotenv::var("GH_OAUTH_REDIRECT_URI").unwrap_or("http://localhost:8808/".to_owned());
291 + let client_id =
292 + dotenv::var("GH_OAUTH_CLIENT_ID").unwrap_or("Please set GH_OAUTH_CLIENT_ID".to_owned());
293 + let redirect_uri = dotenv::var("GH_OAUTH_REDIRECT_URI")
294 + .unwrap_or("Please set GH_OAUTH_REDIRECT_URI".to_owned());
295 let mut url_builder = URLBuilder::new();
296 url_builder
297 .set_protocol("https")