[CI] Fix NIXL push worker test stub after failure deferral (#56955)
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com>
Kevin H. Luu committed
Sep 15, 2026 at 02:00 UTC
2983fc62869de7943bd68ea58730eec7a39ff597
1 file changed
+5
-3
tests/v1/kv_connector/unit/test_nixl_push_connector.py
+5
-3
@@ -351,6 +351,7 @@ class _StubWriterWorker(NixlPushConnectorWorker):
351
# Base worker fields touched by start_load_kv / _get_new_notifs.
352
w._recving_metadata = {}
353
w._pending_recv_notifs = {}
354
+ w._failed_recv_reqs = queue.Queue()
355
w._recv_failures = set()
356
w._recving_transfers = defaultdict(list)
357
w._reqs_to_process = set()
@@ -455,12 +456,14 @@ class TestPushWriterRegSend:
456
list(group) for group in rd["local_block_ids"]
457
]
458
458
- def test_fails_request_when_engine_not_handshaked(self):
459
+ def test_queues_failed_request_when_engine_not_handshaked(self):
460
w, failures = self._reg_send_worker()
461
462
w._do_send_reg_notif("req-1", _registration_data("req-1"))
463
463
- assert failures == [("req-1", None)]
464
+ assert failures == []
465
+ assert w._failed_recv_reqs.get_nowait() == "req-1"
466
+ assert w._failed_recv_reqs.empty()
467
w.nixl_wrapper.send_notif.assert_not_called()
468
469
def test_agent_read_is_serialized_with_handshake_lock(self):
@@ -886,7 +889,6 @@ class TestPushWriterNotifs:
889
w.nixl_wrapper = MagicMock()
890
w.xfer_stats = MagicMock()
891
w._log_failure = MagicMock() # type: ignore[method-assign]
889
- w._failed_recv_reqs = queue.Queue()
892
w._invalid_block_ids = queue.Queue()
893
w._pending_recv_notifs = {}
894
w._replicated_pcp_done_sending = set()