A high-throughput and memory-efficient inference and serving engine for LLMs
Mirrored from https://github.com/tduncan-lum/Nvidia-Optimization-Stack---VLLM.git
Synced Nov 4, 21:15 UTC
[ROCm] [Wheel] [Bugfix] [Critical] Remove any packages installed from github from rocm.txt e.g `fastsafetensors` as it is incompatible with `uv pip` (#40461)
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
TJian committed
Apr 22, 2026 at 09:18 UTC
583e6f22269c15ff3f69431b756486c64bf3ea0c
3 files changed
+26
-6
docker/Dockerfile.rocm
+24
@@ -307,6 +307,30 @@ RUN --mount=type=bind,source=.git,target=vllm/.git \
307
&& echo "Detected vLLM version: ${VLLM_VERSION}" \
308
&& echo "${VLLM_VERSION}" > /tmp/vllm_version.txt
309
310
+# Fail if git-based package dependencies are found in requirements files
311
+# (uv doesn't handle git+ URLs well, and packages should be distributed on PyPI)
312
+# Extra notes: pip install is able to handle git+ URLs, but uv doesn't.
313
+RUN echo "Checking for git-based packages in requirements files..." \
314
+ && echo "Checking common.txt for git-based packages:" \
315
+ && if grep -q 'git+' ${COMMON_WORKDIR}/vllm/requirements/common.txt; then \
316
+ echo "ERROR: Git-based packages found in common.txt:"; \
317
+ grep 'git+' ${COMMON_WORKDIR}/vllm/requirements/common.txt; \
318
+ echo "Please publish these packages to PyPI instead of using git dependencies."; \
319
+ exit 1; \
320
+ else \
321
+ echo " ✓ No git-based packages found in common.txt"; \
322
+ fi \
323
+ && echo "Checking rocm.txt for git-based packages:" \
324
+ && if grep -q 'git+' ${COMMON_WORKDIR}/vllm/requirements/rocm.txt; then \
325
+ echo "ERROR: Git-based packages found in rocm.txt:"; \
326
+ grep 'git+' ${COMMON_WORKDIR}/vllm/requirements/rocm.txt; \
327
+ echo "Please publish these packages to PyPI instead of using git dependencies."; \
328
+ exit 1; \
329
+ else \
330
+ echo " ✓ No git-based packages found in rocm.txt"; \
331
+ fi \
332
+ && echo "All requirements files are clean - no git-based packages found"
333
+
334
# Pin vLLM dependencies to exact versions of custom ROCm wheels
335
# This ensures 'pip install vllm' automatically installs correct torch/triton/torchvision/amdsmi
336
COPY tools/vllm-rocm/pin_rocm_dependencies.py /tmp/pin_rocm_dependencies.py
requirements/rocm.txt
+1
-3
@@ -20,6 +20,4 @@ conch-triton-kernels==1.2.1
20
timm>=1.0.17
21
# amd-quark: required for Quark quantization on ROCm
22
# To be consistent with test_quark.py
23
-amd-quark>=0.8.99
24
-# Required for faster safetensors model loading
25
-fastsafetensors @ git+https://github.com/foundation-model-stack/fastsafetensors.git@0.2.2
\ No newline at end of file
23
+amd-quark>=0.8.99
\ No newline at end of file
requirements/test/rocm.txt
+1
-3
@@ -276,9 +276,7 @@ fastar==0.10.0
276
fastparquet==2026.3.0
277
# via genai-perf
278
fastsafetensors @ git+https://github.com/foundation-model-stack/fastsafetensors.git@65d80088fca7a8f567fba30415fbcc80f7d2259c
279
- # via
280
- # -c requirements/rocm.txt
281
- # -r requirements/test/rocm.in
279
+ # via -r requirements/test/rocm.in
280
filelock==3.25.2
281
# via
282
# -c requirements/common.txt