A high-throughput and memory-efficient inference and serving engine for LLMs
Mirrored from https://github.com/tduncan-lum/Nvidia-Optimization-Stack---VLLM.git
Synced Nov 15, 22:15 UTC
[Misc] Deprecate `--dataset` from `benchmark_serving.py` (#13708)
Signed-off-by: Roger Wang <ywang@roblox.com>
Roger Wang committed
Feb 23, 2025 at 05:32 UTC
9bebc9512f9340e94579b9bd69cfdc452c4d5bb0
1 file changed
+4
-19
benchmarks/benchmark_serving.py
+4
-19
@@ -867,18 +867,10 @@ def main(args: argparse.Namespace):
867
tokenizer_mode=tokenizer_mode,
868
trust_remote_code=args.trust_remote_code)
869
870
- if args.dataset is not None:
871
- warnings.warn(
872
- "The '--dataset' argument will be deprecated in the next "
873
- "release. Please use '--dataset-name' and "
874
- "'--dataset-path' in the future runs.",
875
- stacklevel=2)
876
- input_requests = sample_sharegpt_requests(
877
- dataset_path=args.dataset,
878
- num_requests=args.num_prompts,
879
- tokenizer=tokenizer,
880
- fixed_output_len=args.sharegpt_output_len,
881
- )
870
+ if args.dataset_name is None:
871
+ raise ValueError(
872
+ "Please specify '--dataset-name' and the corresponding "
873
+ "'--dataset-path' if required.")
874
875
elif args.dataset_name == "sharegpt":
876
input_requests = sample_sharegpt_requests(
@@ -1052,13 +1044,6 @@ if __name__ == "__main__":
1044
default="/v1/completions",
1045
help="API endpoint.",
1046
)
1055
- parser.add_argument(
1056
- "--dataset",
1057
- type=str,
1058
- default=None,
1059
- help="Path to the ShareGPT dataset, will be deprecated in the "
1060
- "next release.",
1061
- )
1047
parser.add_argument(
1048
"--dataset-name",
1049
type=str,