A high-throughput and memory-efficient inference and serving engine for LLMs
Mirrored from https://github.com/tduncan-lum/Nvidia-Optimization-Stack---VLLM.git
Synced Nov 7, 04:00 UTC
Don't fire ray compatibility webhook when PR or branch is not provided (#36088)
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com>
Jeffrey Wang committed
Mar 5, 2026 at 16:42 UTC
c012a8c477dd78b4444f22568b2bf1b08f2ad813
1 file changed
+17
-9
.buildkite/scripts/check-ray-compatibility.sh
+17
-9
@@ -166,12 +166,19 @@ See [issue #33599](https://github.com/vllm-project/vllm/issues/33599) for contex
166
EOF
167
fi
168
169
-# Notify Slack if webhook is configured.
169
+# Notify Slack if webhook is configured and PR/branch are valid.
170
if [ -n "$RAY_COMPAT_SLACK_WEBHOOK_URL" ]; then
171
- echo ">>> Sending Slack notification"
172
- # Single quotes are intentional: the f-string expressions are Python, not shell.
173
- # shellcheck disable=SC2016
174
- PAYLOAD=$(python3 -c '
171
+ PR="${BUILDKITE_PULL_REQUEST:-}"
172
+ BRANCH="${BUILDKITE_BRANCH:-}"
173
+
174
+ # Skip notification if PR is invalid or branch is empty
175
+ if [[ "$PR" = "false" || -z "$PR" || -z "$BRANCH" ]]; then
176
+ echo ">>> Skipping Slack notification (invalid PR or empty branch: PR=$PR, branch=$BRANCH)"
177
+ else
178
+ echo ">>> Sending Slack notification"
179
+ # Single quotes are intentional: the f-string expressions are Python, not shell.
180
+ # shellcheck disable=SC2016
181
+ PAYLOAD=$(python3 -c '
182
import json, os, sys
183
pr = os.getenv("BUILDKITE_PULL_REQUEST", "N/A")
184
branch = os.getenv("BUILDKITE_BRANCH", "unknown")
@@ -194,10 +201,11 @@ data = {
201
print(json.dumps(data))
202
')
203
197
- HTTP_CODE=$(curl -s -o /dev/null -w "%{http_code}" -X POST "$RAY_COMPAT_SLACK_WEBHOOK_URL" \
198
- -H 'Content-type: application/json' \
199
- -d "$PAYLOAD")
200
- echo " Slack webhook response: $HTTP_CODE"
204
+ HTTP_CODE=$(curl -s -o /dev/null -w "%{http_code}" -X POST "$RAY_COMPAT_SLACK_WEBHOOK_URL" \
205
+ -H 'Content-type: application/json' \
206
+ -d "$PAYLOAD")
207
+ echo " Slack webhook response: $HTTP_CODE"
208
+ fi
209
else
210
echo ">>> Skipping Slack notification (RAY_COMPAT_SLACK_WEBHOOK_URL not set)"
211
fi