[CI] Replace shellcheck-suppressed patterns flagged in #52572 with clean equivalents (#53341)
Signed-off-by: Turner Jabbour <doubleujabbour@gmail.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Turner Jabbour committed
Oct 2, 2026 at 05:30 UTC
e2cb5ee46c31d0d7a10b95560e8d38ef119042d0
3 files changed
+5
-10
.buildkite/scripts/hardware_ci/run-amd-test.sh
+3
-6
@@ -1712,8 +1712,7 @@ if is_multi_node "$commands"; then
1712
# BASH_REMATCH[2] = comma-separated node0 commands
1713
# BASH_REMATCH[3] = comma-separated node1 commands
1714
if [[ "$commands" =~ ^(.*)\[(.*)"] && ["(.*)\]$ ]]; then
1715
- # shellcheck disable=SC2001 # verified equivalent behavior; TODO: switch to param expansion in a follow-up cleanup PR
1716
- prefix=$(echo "${BASH_REMATCH[1]}" | sed 's/;//g')
1715
+ prefix=${BASH_REMATCH[1]//;/}
1716
echo "PREFIX: ${prefix}"
1717
1718
export composite_command="(command rocm-smi || true)"
@@ -1728,10 +1727,8 @@ if is_multi_node "$commands"; then
1727
fi
1728
1729
for i in "${!node0[@]}"; do
1731
- # shellcheck disable=SC2001 # verified equivalent behavior; TODO: switch to param expansion in a follow-up cleanup PR
1732
- command_node_0=$(echo "${node0[i]}" | sed 's/\"//g')
1733
- # shellcheck disable=SC2001 # verified equivalent behavior; TODO: switch to param expansion in a follow-up cleanup PR
1734
- command_node_1=$(echo "${node1[i]}" | sed 's/\"//g')
1730
+ command_node_0=${node0[i]//\"/}
1731
+ command_node_1=${node1[i]//\"/}
1732
1733
step_cmd="./.buildkite/scripts/run-multi-node-test.sh /vllm-workspace/tests 2 2 ${image_name} '${command_node_0}' '${command_node_1}'"
1734
echo "COMMANDS: ${step_cmd}"
tools/install_torchcodec_rocm.sh
+1
-2
@@ -117,8 +117,7 @@ echo "Building TorchCodec (MAX_JOBS=$MAX_JOBS)..."
117
pip wheel . --no-build-isolation --no-deps -w "$BUILD_DIR/dist"
118
119
# Install the built wheel
120
-# shellcheck disable=SC2012 # `ls` sorting is relied on here; TODO: switch to `find` in a follow-up cleanup PR
121
-BUILT_WHEEL=$(ls "$BUILD_DIR/dist"/torchcodec-*.whl 2>/dev/null | head -1)
120
+BUILT_WHEEL=$(find "$BUILD_DIR/dist" -maxdepth 1 -name 'torchcodec-*.whl' -print -quit)
121
if [ -z "$BUILT_WHEEL" ]; then
122
echo "Error: No wheel produced"
123
exit 1
vllm/utils/numa_wrapper.sh
+1
-2
@@ -15,9 +15,8 @@ if ! command -v numactl >/dev/null 2>&1; then
15
exit 1
16
fi
17
18
-# shellcheck disable=SC1001 # verified equivalent behavior; TODO: revisit escaping in a follow-up cleanup PR
18
case "${_VLLM_INTERNAL_NUMACTL_ARGS}" in
20
- *[![:alnum:]\ \-\_=,./]*)
19
+ *[![:alnum:]\ _=,./-]*)
20
echo "Invalid characters in _VLLM_INTERNAL_NUMACTL_ARGS" >&2
21
exit 1
22
;;