A high-throughput and memory-efficient inference and serving engine for LLMs
Mirrored from https://github.com/tduncan-lum/Nvidia-Optimization-Stack---VLLM.git
Synced Nov 8, 11:15 UTC
[CI][BugFix] Fix silent failure in shellcheck hook and baseline exist… (#32458)
Signed-off-by: junuxyz <216036880+junuxyz@users.noreply.github.com>
junuxyz committed
Feb 12, 2026 at 02:03 UTC
fa7e0bfacfb44ec77a4bda77ba499d320b14ae7c
2 files changed
+126
-2
tools/pre_commit/shellcheck.baseline
new
+89
@@ -0,0 +1,89 @@
1
+benchmarks/auto_tune/auto_tune.sh:SC2034
2
+benchmarks/auto_tune/auto_tune.sh:SC2086
3
+benchmarks/auto_tune/batch_auto_tune.sh:SC2086
4
+benchmarks/run_structured_output_benchmark.sh:SC2028
5
+benchmarks/run_structured_output_benchmark.sh:SC2034
6
+benchmarks/run_structured_output_benchmark.sh:SC2086
7
+.buildkite/image_build/image_build_cpu_arm64.sh:SC2086
8
+.buildkite/image_build/image_build_cpu.sh:SC2086
9
+.buildkite/image_build/image_build_hpu.sh:SC2086
10
+.buildkite/lm-eval-harness/run-lm-eval-chartqa-vllm-vlm-baseline.sh:SC2086
11
+.buildkite/lm-eval-harness/run-lm-eval-mmlupro-vllm-baseline.sh:SC2034
12
+.buildkite/performance-benchmarks/scripts/run-performance-benchmarks.sh:SC2027
13
+.buildkite/performance-benchmarks/scripts/run-performance-benchmarks.sh:SC2086
14
+.buildkite/performance-benchmarks/scripts/run-performance-benchmarks.sh:SC2126
15
+.buildkite/scripts/annotate-rocm-release.sh:SC2086
16
+.buildkite/scripts/cache-rocm-base-wheels.sh:SC2012
17
+.buildkite/scripts/cherry-pick-from-milestone.sh:SC2064
18
+.buildkite/scripts/hardware_ci/run-cpu-test-ppc64le.sh:SC2086
19
+.buildkite/scripts/hardware_ci/run-cpu-test.sh:SC2086
20
+.buildkite/scripts/hardware_ci/run-hpu-test.sh:SC2086
21
+.buildkite/scripts/hardware_ci/run-npu-test.sh:SC1090
22
+.buildkite/scripts/hardware_ci/run-npu-test.sh:SC2006
23
+.buildkite/scripts/hardware_ci/run-npu-test.sh:SC2086
24
+.buildkite/scripts/hardware_ci/run-npu-test.sh:SC2181
25
+.buildkite/scripts/hardware_ci/run-xpu-test.sh:SC2086
26
+.buildkite/scripts/push-nightly-builds.sh:SC2086
27
+.buildkite/scripts/run-multi-node-test.sh:SC2086
28
+.buildkite/scripts/run-multi-node-test.sh:SC2089
29
+.buildkite/scripts/run-multi-node-test.sh:SC2090
30
+.buildkite/scripts/run-prime-rl-test.sh:SC2086
31
+.buildkite/scripts/scheduled_integration_test/deepseek_v2_lite_ep_eplb.sh:SC2086
32
+.buildkite/scripts/scheduled_integration_test/qwen30b_a3b_fp8_block_ep_eplb.sh:SC2086
33
+.buildkite/scripts/scheduled_integration_test/qwen3_next_mtp_async_eplb.sh:SC2086
34
+.buildkite/scripts/tpu/docker_run_bm.sh:SC1090
35
+.buildkite/scripts/tpu/docker_run_bm.sh:SC2086
36
+.buildkite/scripts/tpu/run_bm.sh:SC2034
37
+.buildkite/scripts/tpu/run_bm.sh:SC2086
38
+.buildkite/scripts/upload-nightly-wheels.sh:SC2086
39
+.buildkite/scripts/upload-nightly-wheels.sh:SC2115
40
+.buildkite/scripts/upload-nightly-wheels.sh:SC2236
41
+.buildkite/scripts/upload-release-wheels-pypi.sh:SC2086
42
+.buildkite/scripts/upload-rocm-wheels.sh:SC2012
43
+examples/online_serving/disaggregated_encoder/disagg_1e1p1d_example.sh:SC2086
44
+examples/online_serving/disaggregated_encoder/disagg_1e1pd_example.sh:SC2086
45
+examples/online_serving/disaggregated_prefill.sh:SC2086
46
+examples/online_serving/disaggregated_serving/kv_events.sh:SC2086
47
+examples/online_serving/disaggregated_serving/mooncake_connector/run_mooncake_connector.sh:SC2046
48
+examples/online_serving/disaggregated_serving/mooncake_connector/run_mooncake_connector.sh:SC2086
49
+examples/online_serving/disaggregated_serving/mooncake_connector/run_mooncake_connector.sh:SC2317
50
+examples/online_serving/disaggregated_serving_p2p_nccl_xpyd/disagg_example_p2p_nccl_xpyd.sh:SC2046
51
+examples/online_serving/disaggregated_serving_p2p_nccl_xpyd/disagg_example_p2p_nccl_xpyd.sh:SC2086
52
+examples/online_serving/disaggregated_serving_p2p_nccl_xpyd/disagg_example_p2p_nccl_xpyd.sh:SC2317
53
+examples/online_serving/elastic_ep/bench.sh:SC2086
54
+examples/online_serving/elastic_ep/serve_deepseek_v2.sh:SC2086
55
+examples/online_serving/multi-node-serving.sh:SC2006
56
+examples/online_serving/multi-node-serving.sh:SC2086
57
+examples/online_serving/multi-node-serving.sh:SC2181
58
+examples/others/lmcache/disagg_prefill_lmcache_v1/disagg_example_nixl.sh:SC2046
59
+examples/others/lmcache/disagg_prefill_lmcache_v1/disagg_example_nixl.sh:SC2126
60
+examples/others/lmcache/disagg_prefill_lmcache_v1/disagg_example_nixl.sh:SC2181
61
+examples/others/lmcache/disagg_prefill_lmcache_v1/disagg_example_nixl.sh:SC2206
62
+examples/others/lmcache/disagg_prefill_lmcache_v1/disagg_vllm_launcher.sh:SC2086
63
+examples/pooling/embed/openai_embedding_long_text/service.sh:SC2086
64
+tests/standalone_tests/python_only_compile.sh:SC2086
65
+tests/v1/ec_connector/integration/run_epd_correctness_test.sh:SC2086
66
+tests/v1/kv_connector/nixl_integration/config_sweep_accuracy_test.sh:SC2086
67
+tests/v1/kv_connector/nixl_integration/run_accuracy_test.sh:SC2005
68
+tests/v1/kv_connector/nixl_integration/run_accuracy_test.sh:SC2086
69
+tests/v1/kv_connector/nixl_integration/run_accuracy_test.sh:SC2124
70
+tests/v1/kv_connector/nixl_integration/run_accuracy_test.sh:SC2126
71
+tests/v1/kv_connector/nixl_integration/run_accuracy_test.sh:SC2206
72
+tests/v1/kv_connector/nixl_integration/run_edge_case_test.sh:SC2086
73
+tests/v1/kv_connector/nixl_integration/run_edge_case_test.sh:SC2153
74
+tests/v1/kv_connector/nixl_integration/run_tpu_disagg_accuracy_test.sh:SC2086
75
+tests/v1/kv_connector/nixl_integration/run_tpu_disagg_accuracy_test.sh:SC2089
76
+tests/v1/kv_connector/nixl_integration/run_tpu_disagg_accuracy_test.sh:SC2090
77
+tests/v1/kv_connector/nixl_integration/run_tpu_edge_case_test.sh:SC2086
78
+tests/v1/kv_connector/nixl_integration/run_tpu_edge_case_test.sh:SC2089
79
+tests/v1/kv_connector/nixl_integration/run_tpu_edge_case_test.sh:SC2090
80
+tools/ep_kernels/elastic_ep/install_eep_libraries.sh:SC2086
81
+tools/ep_kernels/install_python_libraries.sh:SC2086
82
+tools/ep_kernels/install_python_libraries.sh:SC2196
83
+tools/flashinfer-build.sh:SC2086
84
+tools/flashinfer-build.sh:SC2269
85
+tools/install_deepgemm.sh:SC2035
86
+tools/install_deepgemm.sh:SC2295
87
+tools/pre_commit/shellcheck.sh:SC2016
88
+tools/vllm-rocm/generate-rocm-wheels-root-index.sh:SC2295
89
+tools/vllm-tpu/build.sh:SC2145
tools/pre_commit/shellcheck.sh
+37
-2
@@ -1,7 +1,8 @@
1
#!/bin/bash
2
-set -e
2
+set -euo pipefail
3
4
scversion="stable"
5
+baseline="tools/pre_commit/shellcheck.baseline"
6
7
if [ -d "shellcheck-${scversion}" ]; then
8
export PATH="$PATH:$(pwd)/shellcheck-${scversion}"
@@ -19,4 +20,38 @@ if ! [ -x "$(command -v shellcheck)" ]; then
20
fi
21
22
# TODO - fix warnings in .buildkite/scripts/hardware_ci/run-amd-test.sh
22
-find . -name "*.sh" ".git" -prune -not -path "./.buildkite/scripts/hardware_ci/run-amd-test.sh" -print0 | xargs -0 -I {} sh -c 'git check-ignore -q "{}" || shellcheck -s bash "{}"'
23
+# collects warnings as "file:SCcode" pairs for baseline comparison.
24
+collect() {
25
+ find . -path ./.git -prune -o -name "*.sh" \
26
+ -not -path "./.buildkite/scripts/hardware_ci/run-amd-test.sh" -print0 | \
27
+ xargs -0 sh -c 'for f in "$@"; do git check-ignore -q "$f" || shellcheck -s bash -f gcc "$f" || true; done' -- | \
28
+ sed -nE 's|^\./||; s|^([^:]+):[0-9]+:[0-9]+:.*\[(SC[0-9]+)\]$|\1:\2|p' | \
29
+ sort -u
30
+}
31
+
32
+if [[ "${1:-}" == "--generate-baseline" ]]; then
33
+ collect > "$baseline"
34
+ echo "Wrote baseline to $baseline"
35
+ exit 0
36
+fi
37
+
38
+if [[ ! -f "$baseline" ]]; then
39
+ echo "Baseline not found: $baseline (run: $0 --generate-baseline)"
40
+ exit 1
41
+fi
42
+
43
+current="$(mktemp)"
44
+trap 'rm -f "$current"' EXIT
45
+collect > "$current"
46
+
47
+# finds new warnings not in baseline
48
+new_errors="$(comm -23 "$current" <(sort -u "$baseline") || true)"
49
+if [ -n "$new_errors" ]; then
50
+ echo "$new_errors" | cut -d: -f1 | sort -u | while IFS= read -r file; do
51
+ if [[ -f "$file" ]]; then
52
+ codes=$(echo "$new_errors" | awk -F: -v f="$file" '$1==f {print $2}' | paste -sd ',' -)
53
+ shellcheck -s bash --include="$codes" "$file" 2>&1 || true
54
+ fi
55
+ done
56
+ exit 1
57
+fi